From: Roland Schwingel <roland.schwingel@onevision.de>
To: Tristan Gingold <gingold@adacore.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Pedro Alves <palves@redhat.com>,
"gdb-patches@sourceware.org ml"
<gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] Windows x64 SEH unwinder
Date: Thu, 22 Aug 2013 12:07:00 -0000 [thread overview]
Message-ID: <5215FEE2.9050407@onevision.de> (raw)
Hi Tristan...
gdb-patches-owner@sourceware.org wrote on 22.08.2013 11:33:10:
> Hello,
>
> after discussion with Roland Schwingel, I have found that the patch
> doesn't handle well dwarf3 DW_OP_call_frame_cfa, because the SEH
> unwinder is before the dwarf2 one.
>
> So I propose this new patch. The only change is the position of the
> SEH unwinder: it is appended after the dwarf2 one.
> As a consequence, old binaries should work too.
I just gave your new patch a brief trial with my gcc 4.8.2. I can
confirm that unwinding now works as it should. I tried it with both
-g and -gdwarf-2 in gcc 4.8.2.
Thank your very much! This finally fixes my 8 years old issue.
(see http://sourceware.org/ml/gdb/2005-04/msg00113.html)
When an application crashes on windows I can see the the stack trace
again (as it has been with gdb 5.3 in the past). Variable inspection
with your v3 patch is also now working. No more errors.
SEH unwinding only works for 64bit but this is perfectly ok for me as I
am fully 64bit for quite a while now!
IMHO I would say ok to commit :-)
This is IMHO a killer feature for the next gdb...
Roland
next reply other threads:[~2013-08-22 12:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 12:07 Roland Schwingel [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-01-09 10:53 Add Windows x64 SEH unwinder (take 2) Joel Brobecker
2013-01-09 10:53 ` [RFA/commit+doco 2/2] Windows x64 SEH unwinder Joel Brobecker
2013-01-09 15:52 ` Pedro Alves
2013-01-09 16:28 ` Tristan Gingold
2013-01-09 17:10 ` Pedro Alves
2013-01-09 20:07 ` Tristan Gingold
2013-01-10 16:24 ` Pedro Alves
2013-07-08 10:55 ` [RFA] Windows x64 SEH unwinder (v2) Tristan Gingold
2013-07-26 15:22 ` Pedro Alves
2013-08-22 9:33 ` [PATCH v3] Windows x64 SEH unwinder Tristan Gingold
2013-08-22 15:10 ` Eli Zaretskii
2013-08-22 15:26 ` Pedro Alves
2013-08-22 15:41 ` Tristan Gingold
2013-08-22 16:15 ` Pedro Alves
2013-08-23 6:54 ` Tristan Gingold
2013-08-27 17:45 ` Pedro Alves
2013-09-02 9:28 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5215FEE2.9050407@onevision.de \
--to=roland.schwingel@onevision.de \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox