From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15808 invoked by alias); 27 Aug 2013 17:45:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15799 invoked by uid 89); 27 Aug 2013 17:45:56 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Aug 2013 17:45:56 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7RHjfZR012010 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Aug 2013 13:45:41 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7RHjb0V028370; Tue, 27 Aug 2013 13:45:39 -0400 Message-ID: <521CE5C1.2030700@redhat.com> Date: Tue, 27 Aug 2013 17:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tristan Gingold CC: "gdb-patches@sourceware.org ml" , Joel Brobecker , Roland Schwingel Subject: Re: [PATCH v3] Windows x64 SEH unwinder References: <1357728781-15073-1-git-send-email-brobecker@adacore.com> <1357728781-15073-3-git-send-email-brobecker@adacore.com> <50ED9221.1050504@redhat.com> <9E84DF2D-7AF8-4AA1-A5DF-171EF189A6E7@adacore.com> <50EDA48E.2030406@redhat.com> <66611BA9-4536-42B2-A65C-4EA5DA219E22@adacore.com> <50EEEB3C.9050202@redhat.com> <5BE11EDB-7832-4489-8CB1-6382F5D1D34E@adacore.com> <51F29440.3030808@redhat.com> <6F12353E-D32C-40F0-87BF-AA77FC15BE03@adacore.com> <52162DA9.5060108@redhat.com> <848C81AC-2171-412B-A6F2-101352933F3E@adacore.com> <52163929.1090008@redhat.com> <9FD66EEA-C685-4F32-8F91-F9E0FF6AAAEE@adacore.com> In-Reply-To: <9FD66EEA-C685-4F32-8F91-F9E0FF6AAAEE@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00793.txt.bz2 Hi there, On 08/23/2013 07:53 AM, Tristan Gingold wrote: > > On Aug 22, 2013, at 6:15 PM, Pedro Alves wrote: >> I'm guessing that using SEH if available would >> be better over dwarf2 (though I don't know for sure). > > Why ? No particular reason -- I guess I got confused by earlier discussions in v1/v2, and I understood it as such. > I think that both unwinders should be correct. One might > be faster than the other, but I don't know which. Okay. > >> And, this version is then a compromise. Right? > > The only compromise is when there are no unwind infos. Previously > a default unwinder based on heuristic was used (doesn't work well, > particularly for MS dll). With the patch, they are considered as > leaf functions by the SEH unwinder. Okay. FAOD, the patch is fine with me. -- Pedro Alves