From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: lgustavo@codesourcery.com,
"'gdb-patches@sourceware.org'"
<gdb-patches@sourceware.org>
Subject: Re: [PATCH] Refactor common/target-common into meaningful bits
Date: Thu, 01 Aug 2013 17:54:00 -0000 [thread overview]
Message-ID: <51FAA0C5.2000508@redhat.com> (raw)
In-Reply-To: <87vc3pfghs.fsf@fleche.redhat.com>
On 08/01/2013 06:49 PM, Tom Tromey wrote:
> If I may be permitted to bikeshed just a bit longer...
>
> Right now the file is named "target/target-waitstatus.h" and the code
> says:
>
> +#include "target-waitstatus.h"
>
>
> I wonder whether you considered naming the file "target/waitstatus.h"
> and having the code say:
>
> +#include "target/waitstatus.h"
>
>
> That is, let the directory provide the namespace service for us.
+1 !
--
Pedro Alves
next prev parent reply other threads:[~2013-08-01 17:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 17:09 Luis Machado
2013-08-01 17:50 ` Tom Tromey
2013-08-01 17:52 ` Luis Machado
2013-08-02 9:29 ` Pedro Alves
2013-08-02 20:48 ` Tom Tromey
2013-08-05 10:44 ` Pedro Alves
2013-08-05 15:33 ` Luis Machado
2013-08-05 19:12 ` Tom Tromey
2013-08-05 19:21 ` Mark Kettenis
2013-08-06 8:48 ` Pedro Alves
2013-08-04 12:35 ` Yao Qi
2013-08-01 17:54 ` Pedro Alves [this message]
2013-08-16 14:49 ` Luis Machado
2013-08-17 4:01 ` Luis Machado
2013-08-19 13:45 ` Pedro Alves
2013-08-19 16:57 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FAA0C5.2000508@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox