From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11301 invoked by alias); 1 Aug 2013 17:54:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11292 invoked by uid 89); 1 Aug 2013 17:54:24 -0000 X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 17:54:24 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r71HsGDx011446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 1 Aug 2013 13:54:16 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r71HsEbQ021902; Thu, 1 Aug 2013 13:54:15 -0400 Message-ID: <51FAA0C5.2000508@redhat.com> Date: Thu, 01 Aug 2013 17:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: lgustavo@codesourcery.com, "'gdb-patches@sourceware.org'" Subject: Re: [PATCH] Refactor common/target-common into meaningful bits References: <51FA9649.5060008@codesourcery.com> <87vc3pfghs.fsf@fleche.redhat.com> In-Reply-To: <87vc3pfghs.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00043.txt.bz2 On 08/01/2013 06:49 PM, Tom Tromey wrote: > If I may be permitted to bikeshed just a bit longer... > > Right now the file is named "target/target-waitstatus.h" and the code > says: > > +#include "target-waitstatus.h" > > > I wonder whether you considered naming the file "target/waitstatus.h" > and having the code say: > > +#include "target/waitstatus.h" > > > That is, let the directory provide the namespace service for us. +1 ! -- Pedro Alves