From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: tromey@redhat.com
Cc: palves@redhat.com, lgustavo@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Refactor common/target-common into meaningful bits
Date: Mon, 05 Aug 2013 19:21:00 -0000 [thread overview]
Message-ID: <201308051920.r75JKhN7009020@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <87bo5c7y0x.fsf@fleche.redhat.com> (message from Tom Tromey on Mon, 05 Aug 2013 13:11:58 -0600)
> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 05 Aug 2013 13:11:58 -0600
>
> >>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> I've read your email several times over, and I sense that we're
> Pedro> talking past each other.
>
> Yeah. And thanks for your follow-up, I think it is clarifying.
>
> Pedro> Yep. So, if we move the classic "target" bits to a "target/"
> Pedro> module directory, and put the native bits in their own dir, we
> Pedro> have:
>
> Pedro> target/resume.h
> Pedro> target/waitstatus.[c|h]
> Pedro> target/wait.h
> Pedro> nat/i386-nat.c
> Pedro> nat/linux-nat.c
> Pedro> nat/linux-ptrace.c
> Pedro> nat/linux-waitpid.c
> Pedro> etc.
>
> Pedro> Is this what you're thinking of? _This_, I'm fine with.
>
> Yeah, this is what I think we ought to do.
>
> Pedro> It's actually very similar to something else I suggested on IRC,
> Pedro> but forgot to put in email form: "IMO, the interfaces themselves
> Pedro> would be in an include dir. e.g.,
> Pedro> gdb/include/target-waitstatus.h or some such, and then we'd have
> Pedro> gdb/nat/linux-nat.c, etc."
>
> I'm usually against include dirs, but if they are near enough to the
> implementation it is ok by me. My issue with them is mainly
> forgettability -- like, I never, ever remember to look for things in
> src/include/gdb; and then directories like this tend to become forgotten
> graveyards.
Yea, we shouldn't put anything in src/include/gdb unless it is
absolutely necessary. That pretty much translates into "unless sim
needs it".
next prev parent reply other threads:[~2013-08-05 19:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 17:09 Luis Machado
2013-08-01 17:50 ` Tom Tromey
2013-08-01 17:52 ` Luis Machado
2013-08-02 9:29 ` Pedro Alves
2013-08-02 20:48 ` Tom Tromey
2013-08-05 10:44 ` Pedro Alves
2013-08-05 15:33 ` Luis Machado
2013-08-05 19:12 ` Tom Tromey
2013-08-05 19:21 ` Mark Kettenis [this message]
2013-08-06 8:48 ` Pedro Alves
2013-08-04 12:35 ` Yao Qi
2013-08-01 17:54 ` Pedro Alves
2013-08-16 14:49 ` Luis Machado
2013-08-17 4:01 ` Luis Machado
2013-08-19 13:45 ` Pedro Alves
2013-08-19 16:57 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308051920.r75JKhN7009020@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox