From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <lgustavo@codesourcery.com>, Tom Tromey <tromey@redhat.com>,
"'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Refactor common/target-common into meaningful bits
Date: Sun, 04 Aug 2013 12:35:00 -0000 [thread overview]
Message-ID: <51FE4A63.9030005@codesourcery.com> (raw)
In-Reply-To: <51FB7BFB.90100@redhat.com>
On 08/02/2013 05:29 PM, Pedro Alves wrote:
> "target" is an overloaded word in GDB-speak. My idea for this new
> directory, would be for it to hold the native target backend bits.
> But "target" could also suggest that corelow.c, file.c, remote.c, etc.
> should be put in this directory, while I don't think they should.
If we don't move corelow.c and remote.c to "target" directory, that is
not confusing. People will get to know the meaning of the directory
when they list the files in this directory. For example, there is a
directory "Target" in LLDB source tree lldb/source/Target, and I get to
know what does "Target" mean in LLDB when I list the files in it.
>
> Sounds like a better name for this native target backend directory
> should be invented. GDB uses *-nat.c naming for most of
> these files, while GDBserver uses *-low.c.
>
> ( "low" itself in GDBserver is also ambiguous -- e.g., linux-low.h
> introduces the "struct linux_target_ops", and we call_that_ the
> "low target" at places (seems its my own fault for introducing
> that ambiguity...) ... )
>
> So to me that suggests "nat", "native" or "low", in my order
> of preference.
I feel "target" is better than them, so I prefer "target".
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-08-04 12:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 17:09 Luis Machado
2013-08-01 17:50 ` Tom Tromey
2013-08-01 17:52 ` Luis Machado
2013-08-02 9:29 ` Pedro Alves
2013-08-02 20:48 ` Tom Tromey
2013-08-05 10:44 ` Pedro Alves
2013-08-05 15:33 ` Luis Machado
2013-08-05 19:12 ` Tom Tromey
2013-08-05 19:21 ` Mark Kettenis
2013-08-06 8:48 ` Pedro Alves
2013-08-04 12:35 ` Yao Qi [this message]
2013-08-01 17:54 ` Pedro Alves
2013-08-16 14:49 ` Luis Machado
2013-08-17 4:01 ` Luis Machado
2013-08-19 13:45 ` Pedro Alves
2013-08-19 16:57 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FE4A63.9030005@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox