From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/9] Rely on gnulib's unistd.h replacement.
Date: Fri, 28 Jun 2013 18:11:00 -0000 [thread overview]
Message-ID: <51CDD08F.8010708@redhat.com> (raw)
In-Reply-To: <51CDCB80.1010400@redhat.com>
On 06/28/2013 06:44 PM, Pedro Alves wrote:
> On 06/28/2013 09:48 AM, Yao Qi wrote:
>> On 06/28/2013 02:52 AM, Pedro Alves wrote:
>>> With gnulib's unistd module, we can assume unistd.h is always present, and that
>>> STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO are always defined.
>>
>> So we don't have to check unistd.h by AC_CHECK_HEADERS in
>> gdb/configure.ac and gdb/gdbserver/configure.ac?
>>
>
> Yeah. I had chickened out on it, thinking it might be still
> necessary for the following autoconf checks, after seeing that
> string.h strings.h etc. are still checked too. But if that's
> the case, then the following the tests that need it should be
> fixed instead, so I agree if should be removed.
I take that back. I managed to get myself confused, and kind of
forget what I saw yesterday.
We have this in configure.ac:
# Check the return and argument types of ptrace. No canned test for
# this, so roll our own.
gdb_ptrace_headers='
#if HAVE_SYS_TYPES_H
# include <sys/types.h>
#endif
#if HAVE_SYS_PTRACE_H
# include <sys/ptrace.h>
#endif
#if HAVE_UNISTD_H
# include <unistd.h>
#endif
See my other message to Tom.
--
Pedro Alves
next prev parent reply other threads:[~2013-06-28 18:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 18:52 [PATCH 00/09] Import unistd and pathmax gnulib modules Pedro Alves
2013-06-27 18:52 ` [PATCH 4/9] Rely on gnulib's unistd.h replacement Pedro Alves
2013-06-28 9:05 ` Yao Qi
2013-06-28 17:44 ` Pedro Alves
2013-06-28 18:11 ` Pedro Alves [this message]
2013-06-27 18:52 ` [PATCH 1/9] Reimport gnulib from scratch Pedro Alves
2013-06-28 8:49 ` Yao Qi
2013-06-28 9:55 ` Pedro Alves
2013-06-28 12:10 ` Yao Qi
2013-06-28 12:28 ` Pedro Alves
2013-06-27 18:52 ` [PATCH 2/9] utils.c: pathconf call, check for _PC_PATH_MAX instead of HAVE_UNISTD_H Pedro Alves
2013-06-27 18:52 ` [PATCH 5/9] Constify main.c:get_init_files Pedro Alves
2013-06-27 18:52 ` [PATCH 6/9] Reimplement DJGPP's .gdbinit -> gdb.ini renaming Pedro Alves
2013-06-27 18:52 ` [PATCH 3/9] Import the "unistd" gnulib module Pedro Alves
2013-06-27 18:53 ` [PATCH 8/9] Normalize on PATH_MAX instead of MAXPATHLEN throughout Pedro Alves
2013-06-28 15:21 ` Tom Tromey
2013-06-28 18:06 ` Pedro Alves
2013-06-28 19:08 ` Tom Tromey
2013-06-27 18:53 ` [PATCH 7/9] Import the "pathmax" gnulib module Pedro Alves
2013-06-27 18:59 ` [PATCH 9/9] [GDBserver] hostio.c: Fallback to packet buffer size if PATH_MAX is not available Pedro Alves
2013-06-28 15:43 ` [PATCH 00/09] Import unistd and pathmax gnulib modules Tom Tromey
2013-07-01 11:31 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CDD08F.8010708@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox