From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27131 invoked by alias); 28 Jun 2013 18:06:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27031 invoked by uid 89); 28 Jun 2013 18:06:12 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 28 Jun 2013 18:06:11 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5SI69sU029334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Jun 2013 14:06:09 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5SI6734026685; Fri, 28 Jun 2013 14:06:08 -0400 Message-ID: <51CDD08F.8010708@redhat.com> Date: Fri, 28 Jun 2013 18:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/9] Rely on gnulib's unistd.h replacement. References: <20130627185200.6625.10526.stgit@brno.lan> <20130627185229.6625.60141.stgit@brno.lan> <51CD4DEC.6050104@codesourcery.com> <51CDCB80.1010400@redhat.com> In-Reply-To: <51CDCB80.1010400@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00919.txt.bz2 On 06/28/2013 06:44 PM, Pedro Alves wrote: > On 06/28/2013 09:48 AM, Yao Qi wrote: >> On 06/28/2013 02:52 AM, Pedro Alves wrote: >>> With gnulib's unistd module, we can assume unistd.h is always present, and that >>> STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO are always defined. >> >> So we don't have to check unistd.h by AC_CHECK_HEADERS in >> gdb/configure.ac and gdb/gdbserver/configure.ac? >> > > Yeah. I had chickened out on it, thinking it might be still > necessary for the following autoconf checks, after seeing that > string.h strings.h etc. are still checked too. But if that's > the case, then the following the tests that need it should be > fixed instead, so I agree if should be removed. I take that back. I managed to get myself confused, and kind of forget what I saw yesterday. We have this in configure.ac: # Check the return and argument types of ptrace. No canned test for # this, so roll our own. gdb_ptrace_headers=' #if HAVE_SYS_TYPES_H # include #endif #if HAVE_SYS_PTRACE_H # include #endif #if HAVE_UNISTD_H # include #endif See my other message to Tom. -- Pedro Alves