From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/9] Reimport gnulib from scratch.
Date: Fri, 28 Jun 2013 12:10:00 -0000 [thread overview]
Message-ID: <51CD7BEB.5060309@codesourcery.com> (raw)
In-Reply-To: <51CD51F0.1080203@redhat.com>
On 06/28/2013 05:05 PM, Pedro Alves wrote:
> You misunderstand. I never said we_need_ to reimport gnulib in
> order to pull in unistd. This patch is in the series as I based
> subsequent patches on top of it. It isn't strictly necessary,
> and we could do this reimporting after the series instead. Sorry
> if that wasn't clear.
I misunderstood it, because patch 1/9 is one of the patches "Import
unistd and pathmax gnulib modules.", and I never tried removing 'import'
directory and run update-gnulib.sh.
>
>> >Here are my steps,
>> >
>> >1. cd to <my gnulib repository> and check out commit.
>> >8d5bd1402003bd0153984b138735adf537d960b0, which is required by
>> >update-gnulib.sh
>> >
>> >2. Modify update-gnulib.sh to add unistd into IMPORTED_GNULIB_MODULES,
>> >
>> >3. Run 'bash update-gnulib.sh <my gnulib repository>'.
>> >
>> >Here is the diff of aclocal.m4, for the reference sake.
> As you see from your diff, doing things that way preserves
> onlyonce.m4.
>
> Now try what I suggested. Do:
>
> 1.1. mv import import.old
> 1.2. mkdir import
> 1.3. Run 'bash update-gnulib.sh <my gnulib repository>'.
> 1.4. Diff the resulting gnulib/ trees. (or git diff, or whatever)
>
> You'll (I hope) differences similar this patch #1.
>
Yes, I can get the patch #1 in my local tree.
> At this point, one begins to wonder whether unistd is related.
> Then go back to a pristine tree, and do the same exercise,
> but without importing unistd:
>
> 2.1. Run 'bash update-gnulib.sh <my gnulib repository>'.
> 2.2. Diff the result, nothing should have changed.
> 2.2. mv import import.old
> 2.3. mkdir import
> 2.4. Run 'bash update-gnulib.sh <my gnulib repository>'.
> 2.5. Diff the resulting gnulib/ trees.
>
> At 2.5, you should see a diff just like this patch #1.
>
> What I'm saying is that we should be able to generate our gnulib
> import from scratch and end up with the exact same as we have
> in the tree. But, if we actually try doing it, we don't!
>
Agreed. Otherwise, when we upgrade gnulib to a recent commit, we'll get
some unexpected changes in the diff.
> So this patch proposes getting rid of the cruft gnulib-tool is
> leaving behind, and I'm suggesting we should probably be
> doing this always.
So "this" means remove directory 'import', run update-gnulib.sh, and
make sure there is no diff in gdb/gnulib, right?
>
> I'd be interested in knowing if you can reproduce these
> results.
Yeah, I can reproduce that.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-06-28 12:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 18:52 [PATCH 00/09] Import unistd and pathmax gnulib modules Pedro Alves
2013-06-27 18:52 ` [PATCH 3/9] Import the "unistd" gnulib module Pedro Alves
2013-06-27 18:52 ` [PATCH 6/9] Reimplement DJGPP's .gdbinit -> gdb.ini renaming Pedro Alves
2013-06-27 18:52 ` [PATCH 5/9] Constify main.c:get_init_files Pedro Alves
2013-06-27 18:52 ` [PATCH 1/9] Reimport gnulib from scratch Pedro Alves
2013-06-28 8:49 ` Yao Qi
2013-06-28 9:55 ` Pedro Alves
2013-06-28 12:10 ` Yao Qi [this message]
2013-06-28 12:28 ` Pedro Alves
2013-06-27 18:52 ` [PATCH 2/9] utils.c: pathconf call, check for _PC_PATH_MAX instead of HAVE_UNISTD_H Pedro Alves
2013-06-27 18:52 ` [PATCH 4/9] Rely on gnulib's unistd.h replacement Pedro Alves
2013-06-28 9:05 ` Yao Qi
2013-06-28 17:44 ` Pedro Alves
2013-06-28 18:11 ` Pedro Alves
2013-06-27 18:53 ` [PATCH 7/9] Import the "pathmax" gnulib module Pedro Alves
2013-06-27 18:53 ` [PATCH 8/9] Normalize on PATH_MAX instead of MAXPATHLEN throughout Pedro Alves
2013-06-28 15:21 ` Tom Tromey
2013-06-28 18:06 ` Pedro Alves
2013-06-28 19:08 ` Tom Tromey
2013-06-27 18:59 ` [PATCH 9/9] [GDBserver] hostio.c: Fallback to packet buffer size if PATH_MAX is not available Pedro Alves
2013-06-28 15:43 ` [PATCH 00/09] Import unistd and pathmax gnulib modules Tom Tromey
2013-07-01 11:31 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD7BEB.5060309@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox