From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/9] Reimport gnulib from scratch.
Date: Fri, 28 Jun 2013 08:49:00 -0000 [thread overview]
Message-ID: <51CD4C4A.9030605@codesourcery.com> (raw)
In-Reply-To: <20130627185207.6625.27448.stgit@brno.lan>
On 06/28/2013 02:52 AM, Pedro Alves wrote:
> I tried moving aside gnulib/import/, and re-running the our
> gnulib/update-gnulib.sh script, and surprisingly, I get a different
> result compared to what's in the tree. This is with pristine FSF
> autoconf and FSF automake, at the versions required by
> update-gnulib.sh. However, if I just run the update-gnulib.sh scripts
> against the_existing_ tree, then nothing changes... I suspect
> gnulib-tool's merge logic might be preserving some things by design.
> I think we should put this in regardless, as a "get rid of cruft that
> might have accumulated over gnulib updates". onceonly.m4 seems to fit
> in that category.
Pedro,
I tried to run update-gnulib.sh to import module unistd, and the result
looks right to me. Don't know why we need to reimport gnulib here.
Here are my steps,
1. cd to <my gnulib repository> and check out commit.
8d5bd1402003bd0153984b138735adf537d960b0, which is required by
update-gnulib.sh
2. Modify update-gnulib.sh to add unistd into IMPORTED_GNULIB_MODULES,
3. Run 'bash update-gnulib.sh <my gnulib repository>'.
Here is the diff of aclocal.m4, for the reference sake.
$ git diff aclocal.m4
diff --git a/gdb/gnulib/aclocal.m4 b/gdb/gnulib/aclocal.m4
index fb99505..d983131 100644
--- a/gdb/gnulib/aclocal.m4
+++ b/gdb/gnulib/aclocal.m4
@@ -1048,11 +1048,15 @@ m4_include([import/m4/memchr.m4])
m4_include([import/m4/memmem.m4])
m4_include([import/m4/mmap-anon.m4])
m4_include([import/m4/multiarch.m4])
+m4_include([import/m4/off_t.m4])
m4_include([import/m4/onceonly.m4])
+m4_include([import/m4/ssize_t.m4])
m4_include([import/m4/stdbool.m4])
m4_include([import/m4/stddef_h.m4])
m4_include([import/m4/stdint.m4])
m4_include([import/m4/string_h.m4])
+m4_include([import/m4/sys_types_h.m4])
+m4_include([import/m4/unistd_h.m4])
m4_include([import/m4/warn-on-use.m4])
m4_include([import/m4/wchar_h.m4])
m4_include([import/m4/wchar_t.m4])
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-06-28 8:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 18:52 [PATCH 00/09] Import unistd and pathmax gnulib modules Pedro Alves
2013-06-27 18:52 ` [PATCH 5/9] Constify main.c:get_init_files Pedro Alves
2013-06-27 18:52 ` [PATCH 3/9] Import the "unistd" gnulib module Pedro Alves
2013-06-27 18:52 ` [PATCH 6/9] Reimplement DJGPP's .gdbinit -> gdb.ini renaming Pedro Alves
2013-06-27 18:52 ` [PATCH 4/9] Rely on gnulib's unistd.h replacement Pedro Alves
2013-06-28 9:05 ` Yao Qi
2013-06-28 17:44 ` Pedro Alves
2013-06-28 18:11 ` Pedro Alves
2013-06-27 18:52 ` [PATCH 2/9] utils.c: pathconf call, check for _PC_PATH_MAX instead of HAVE_UNISTD_H Pedro Alves
2013-06-27 18:52 ` [PATCH 1/9] Reimport gnulib from scratch Pedro Alves
2013-06-28 8:49 ` Yao Qi [this message]
2013-06-28 9:55 ` Pedro Alves
2013-06-28 12:10 ` Yao Qi
2013-06-28 12:28 ` Pedro Alves
2013-06-27 18:53 ` [PATCH 7/9] Import the "pathmax" gnulib module Pedro Alves
2013-06-27 18:53 ` [PATCH 8/9] Normalize on PATH_MAX instead of MAXPATHLEN throughout Pedro Alves
2013-06-28 15:21 ` Tom Tromey
2013-06-28 18:06 ` Pedro Alves
2013-06-28 19:08 ` Tom Tromey
2013-06-27 18:59 ` [PATCH 9/9] [GDBserver] hostio.c: Fallback to packet buffer size if PATH_MAX is not available Pedro Alves
2013-06-28 15:43 ` [PATCH 00/09] Import unistd and pathmax gnulib modules Tom Tromey
2013-07-01 11:31 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD4C4A.9030605@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox