Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: lgustavo@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix wp-replication.exp for targets that provide only 1 hw watchpoint
Date: Fri, 24 May 2013 14:03:00 -0000	[thread overview]
Message-ID: <519F732C.1050009@linux.vnet.ibm.com> (raw)
In-Reply-To: <519F2084.3090104@codesourcery.com>

On 05/24/2013 05:10 AM, Luis Machado wrote:
> I think i see the problem here. "break" only really jumps out of the
> gdb_test_multiple block instead of breaking, so this would be a problem
> for all targets that do "on the fly" accounting of resources, thus not
> taking the error check leg of the test.

Thanks Luis for the feedback, I think you've narrowed down the problem.
That happens on targets that do 'on the fly' checking of available
watchpoints (like ppc64 does). It's not a matter of number of available
hw watchpoints as my original message suggests.

> Maybe replace both "break" with "continue". We really just want to reach
> the top of the while loop here to either jump out of the loop or
> continue with it.

'continue' doesn't work either. From what I understood, 'break' or
'continue' will terminate the iteration of the innermost nested loop,
that seems to be the gdb_test_multiple block. That's why it continues to
the second gdb_test_multiple block and wrongly increments hwatch_count
instead of going to the beginning of while block.

-- 
Edjunior


      reply	other threads:[~2013-05-24 14:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  3:19 Edjunior Barbosa Machado
2013-05-24  3:26 ` Edjunior Barbosa Machado
2013-05-24  7:32   ` Luis Machado
2013-05-24  8:11     ` Luis Machado
2013-05-24 14:03       ` Edjunior Barbosa Machado [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519F732C.1050009@linux.vnet.ibm.com \
    --to=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox