Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: lgustavo@codesourcery.com
Subject: [PATCH] Fix wp-replication.exp for targets that provide only 1 hw watchpoint
Date: Fri, 24 May 2013 03:26:00 -0000	[thread overview]
Message-ID: <1369365909-14746-1-git-send-email-emachado@linux.vnet.ibm.com> (raw)
In-Reply-To: <1369365561-14567-1-git-send-email-emachado@linux.vnet.ibm.com>

(sorry, my previous message got truncated. Resending...)

Hi,

current wp-replication.exp testcase counts 2 hw watchpoints even when the target
provides only 1 hw watch, resulting in several unexpected errors. Successfully
tested on x86 (with 4 hw watchpoints available) and ppc64 server (with 1 hw
watch), this patch intends to fix this issue. Ok?

Thanks,
--
Edjunior

gdb/testsuite/ChangeLog
2013-05-24  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* gdb.threads/wp-replication.exp: Fix accounting of hardware watchpoints
	on targets that provide only one hw watchpoint.

---
 gdb/testsuite/gdb.threads/wp-replication.exp |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/gdb/testsuite/gdb.threads/wp-replication.exp b/gdb/testsuite/gdb.threads/wp-replication.exp
index 8927a43..f73b763 100644
--- a/gdb/testsuite/gdb.threads/wp-replication.exp
+++ b/gdb/testsuite/gdb.threads/wp-replication.exp
@@ -78,6 +78,10 @@ while { $done == 0 } {
     }
   }
 
+  if { $done == 1 } {
+    break
+  }
+
   gdb_test_multiple "continue" "watchpoint created successfully" {
     -re ".*Breakpoint 2, empty_cycle \\(\\).*$gdb_prompt $" {
       incr hwatch_count
-- 
1.7.1


  reply	other threads:[~2013-05-24  3:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  3:19 Edjunior Barbosa Machado
2013-05-24  3:26 ` Edjunior Barbosa Machado [this message]
2013-05-24  7:32   ` Luis Machado
2013-05-24  8:11     ` Luis Machado
2013-05-24 14:03       ` Edjunior Barbosa Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369365909-14746-1-git-send-email-emachado@linux.vnet.ibm.com \
    --to=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox