From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28873 invoked by alias); 24 May 2013 14:03:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28859 invoked by uid 89); 24 May 2013 14:03:32 -0000 X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,KAM_TIME,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD autolearn=no version=3.3.1 Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 24 May 2013 14:03:32 +0000 Received: from /spool/local by e24smtp01.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 24 May 2013 11:03:29 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp01.br.ibm.com (10.172.0.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 24 May 2013 11:03:26 -0300 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 6455A3520066 for ; Fri, 24 May 2013 10:03:25 -0400 (EDT) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4OE0F2g1831156 for ; Fri, 24 May 2013 11:00:15 -0300 Received: from d24av04.br.ibm.com (localhost [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r4OE3Ojh021462 for ; Fri, 24 May 2013 11:03:24 -0300 Received: from [9.8.6.235] ([9.8.6.235]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r4OE3OO4021445; Fri, 24 May 2013 11:03:24 -0300 Message-ID: <519F732C.1050009@linux.vnet.ibm.com> Date: Fri, 24 May 2013 14:03:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: lgustavo@codesourcery.com CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix wp-replication.exp for targets that provide only 1 hw watchpoint References: <1369365909-14746-1-git-send-email-emachado@linux.vnet.ibm.com> <519F17A0.2040607@codesourcery.com> <519F2084.3090104@codesourcery.com> In-Reply-To: <519F2084.3090104@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13052414-1524-0000-0000-0000063867F4 X-SW-Source: 2013-05/txt/msg00926.txt.bz2 On 05/24/2013 05:10 AM, Luis Machado wrote: > I think i see the problem here. "break" only really jumps out of the > gdb_test_multiple block instead of breaking, so this would be a problem > for all targets that do "on the fly" accounting of resources, thus not > taking the error check leg of the test. Thanks Luis for the feedback, I think you've narrowed down the problem. That happens on targets that do 'on the fly' checking of available watchpoints (like ppc64 does). It's not a matter of number of available hw watchpoints as my original message suggests. > Maybe replace both "break" with "continue". We really just want to reach > the top of the while loop here to either jump out of the loop or > continue with it. 'continue' doesn't work either. From what I understood, 'break' or 'continue' will terminate the iteration of the innermost nested loop, that seems to be the gdb_test_multiple block. That's why it continues to the second gdb_test_multiple block and wrongly increments hwatch_count instead of going to the beginning of while block. -- Edjunior