Re: [PATCH 1/2] Allow expand_symtabs_matching to examine imported psymtabs

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-03-24 4:15 p.m., Tom Tromey wrote:
> Currently the psymtab variant of expand_symtabs_matching has this
> check:
> 
>       /* We skip shared psymtabs because file-matching doesn't apply
> 	 to them; but we search them later in the loop.  */
>       if (ps->user != NULL)
> 	continue;
> 
> In a larger series I'm working on, it's convenient to remove this
> check.  And, I noticed that a similar check is not done for
> expand_symtabs_with_fullname.  So, it made sense to me to remove the
> check here as well.
> 
> gdb/ChangeLog
> 2021-03-24  Tom Tromey  <tom@tromey.com>
> 
> 	* psymtab.c (psymbol_functions::expand_symtabs_matching): Remove
> 	"user" check.
> ---
>  gdb/ChangeLog | 5 +++++
>  gdb/psymtab.c | 5 -----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/gdb/psymtab.c b/gdb/psymtab.c
> index 597817269c1..5a64166d983 100644
> --- a/gdb/psymtab.c
> +++ b/gdb/psymtab.c
> @@ -1313,11 +1313,6 @@ psymbol_functions::expand_symtabs_matching
>        if (ps->readin_p (objfile))
>  	continue;
>  
> -      /* We skip shared psymtabs because file-matching doesn't apply
> -	 to them; but we search them later in the loop.  */
> -      if (ps->user != NULL)
> -	continue;
> -
>        if (file_matcher)
>  	{
>  	  bool match;
> 

I'm not against this change, but I don't understand it.  It seems
logical to me to skip shared psymtabs, because we'll reach them through
some other psymtabs that include them.  So, both versions seem correct,
but maybe knowing why it's convenient to you would help.

Simon