From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Allow expand_symtabs_matching to examine imported psymtabs
Date: Fri, 26 Mar 2021 14:27:53 -0400 [thread overview]
Message-ID: <8d703a88-7ff7-bc74-5e3d-cee32c6c8608@polymtl.ca> (raw)
In-Reply-To: <8735whg4oo.fsf@tromey.com>
On 2021-03-26 2:17 p.m., Tom Tromey wrote:>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
>>> - /* We skip shared psymtabs because file-matching doesn't apply
>>> - to them; but we search them later in the loop. */
>>> - if (ps->user != NULL)
>>> - continue;
>>> -
>
> Simon> I'm not against this change, but I don't understand it. It seems
> Simon> logical to me to skip shared psymtabs, because we'll reach them through
> Simon> some other psymtabs that include them. So, both versions seem correct,
> Simon> but maybe knowing why it's convenient to you would help.
>
> If the shared psymtab has a file name, then that file name will not be
> checked by the file matcher. This doesn't matter directly now because
> file matching is often done via a different method, that does check
> these. However, with my proposed series to remove the redundant
> methods, this issue is exposed.
Ok, thanks.
Simon
next prev parent reply other threads:[~2021-03-26 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 20:15 [PATCH 0/2] Two minor partial symtab cleanups Tom Tromey
2021-03-24 20:15 ` [PATCH 1/2] Allow expand_symtabs_matching to examine imported psymtabs Tom Tromey
2021-03-25 19:29 ` Simon Marchi via Gdb-patches
2021-03-26 18:17 ` Tom Tromey
2021-03-26 18:27 ` Simon Marchi via Gdb-patches [this message]
2021-03-24 20:15 ` [PATCH 2/2] Simplify psymbol_functions::expand_symtabs_matching Tom Tromey
2021-03-25 19:31 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d703a88-7ff7-bc74-5e3d-cee32c6c8608@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox