From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 1/2] Allow expand_symtabs_matching to examine imported psymtabs
Date: Wed, 24 Mar 2021 14:15:09 -0600 [thread overview]
Message-ID: <20210324201510.23655-2-tom@tromey.com> (raw)
In-Reply-To: <20210324201510.23655-1-tom@tromey.com>
Currently the psymtab variant of expand_symtabs_matching has this
check:
/* We skip shared psymtabs because file-matching doesn't apply
to them; but we search them later in the loop. */
if (ps->user != NULL)
continue;
In a larger series I'm working on, it's convenient to remove this
check. And, I noticed that a similar check is not done for
expand_symtabs_with_fullname. So, it made sense to me to remove the
check here as well.
gdb/ChangeLog
2021-03-24 Tom Tromey <tom@tromey.com>
* psymtab.c (psymbol_functions::expand_symtabs_matching): Remove
"user" check.
---
gdb/ChangeLog | 5 +++++
gdb/psymtab.c | 5 -----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index 597817269c1..5a64166d983 100644
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -1313,11 +1313,6 @@ psymbol_functions::expand_symtabs_matching
if (ps->readin_p (objfile))
continue;
- /* We skip shared psymtabs because file-matching doesn't apply
- to them; but we search them later in the loop. */
- if (ps->user != NULL)
- continue;
-
if (file_matcher)
{
bool match;
--
2.26.2
next prev parent reply other threads:[~2021-03-24 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 20:15 [PATCH 0/2] Two minor partial symtab cleanups Tom Tromey
2021-03-24 20:15 ` Tom Tromey [this message]
2021-03-25 19:29 ` [PATCH 1/2] Allow expand_symtabs_matching to examine imported psymtabs Simon Marchi via Gdb-patches
2021-03-26 18:17 ` Tom Tromey
2021-03-26 18:27 ` Simon Marchi via Gdb-patches
2021-03-24 20:15 ` [PATCH 2/2] Simplify psymbol_functions::expand_symtabs_matching Tom Tromey
2021-03-25 19:31 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324201510.23655-2-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox