From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qB1FJx+eW2AsawAAWB0awg (envelope-from ) for ; Wed, 24 Mar 2021 16:16:31 -0400 Received: by simark.ca (Postfix, from userid 112) id 9E4DC1EF7C; Wed, 24 Mar 2021 16:16:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4B82D1EF5D for ; Wed, 24 Mar 2021 16:16:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13C3E3851C24; Wed, 24 Mar 2021 20:16:31 +0000 (GMT) Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.80]) by sourceware.org (Postfix) with ESMTPS id 4DE193851C24 for ; Wed, 24 Mar 2021 20:16:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4DE193851C24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 9B51C18AA59 for ; Wed, 24 Mar 2021 15:15:11 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id P9uJlUg6dmJLsP9uJlBoeV; Wed, 24 Mar 2021 15:15:11 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fXSW25QpDAR1TaaktqbGJYUWJIEu+v7oa525HgCIn34=; b=oS0UgRpXFLMuXTEi5HfS0IE1MV ky0fh1yZ41OTHD8xgtb+8KvDI9vOHomvdOkPQOQivgt4E2hBX7igdsB3qtljvdPDYfb0OzS2mm3Qu VmqJ0STO4RCV4XKmNBvn8GC/d; Received: from 71-211-130-165.hlrn.qwest.net ([71.211.130.165]:52838 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lP9uJ-001x1i-C0; Wed, 24 Mar 2021 14:15:11 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 1/2] Allow expand_symtabs_matching to examine imported psymtabs Date: Wed, 24 Mar 2021 14:15:09 -0600 Message-Id: <20210324201510.23655-2-tom@tromey.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210324201510.23655-1-tom@tromey.com> References: <20210324201510.23655-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.165 X-Source-L: No X-Exim-ID: 1lP9uJ-001x1i-C0 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-165.hlrn.qwest.net (localhost.localdomain) [71.211.130.165]:52838 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Currently the psymtab variant of expand_symtabs_matching has this check: /* We skip shared psymtabs because file-matching doesn't apply to them; but we search them later in the loop. */ if (ps->user != NULL) continue; In a larger series I'm working on, it's convenient to remove this check. And, I noticed that a similar check is not done for expand_symtabs_with_fullname. So, it made sense to me to remove the check here as well. gdb/ChangeLog 2021-03-24 Tom Tromey * psymtab.c (psymbol_functions::expand_symtabs_matching): Remove "user" check. --- gdb/ChangeLog | 5 +++++ gdb/psymtab.c | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/psymtab.c b/gdb/psymtab.c index 597817269c1..5a64166d983 100644 --- a/gdb/psymtab.c +++ b/gdb/psymtab.c @@ -1313,11 +1313,6 @@ psymbol_functions::expand_symtabs_matching if (ps->readin_p (objfile)) continue; - /* We skip shared psymtabs because file-matching doesn't apply - to them; but we search them later in the loop. */ - if (ps->user != NULL) - continue; - if (file_matcher) { bool match; -- 2.26.2