From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id H9pGDqzkXGBMLwAAWB0awg (envelope-from ) for ; Thu, 25 Mar 2021 15:29:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 2A2EE1EF7C; Thu, 25 Mar 2021 15:29:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8B1701E789 for ; Thu, 25 Mar 2021 15:29:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 41C453858001; Thu, 25 Mar 2021 19:29:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 41C453858001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616700587; bh=nuHe9iBs4HmeROid6JBad9wPOleSlLPlT2yiYxDy8Hc=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=tbGSndvQmttjJ0FYX1Kw4rGmTThtfuZNJtmkFwgsDJKL697+5ikL1uZc+A8CipM8N JX9aL6H3LxsbSpnLrPJ/7T60o/I/fXBijfbXQokxBRqSoGqc6EkCOsRSbawgqY6tMb lJNowNeAxPdsv6hx9LM6DsLKGC0Wtq6vuFKv+ts0= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7A6133858001 for ; Thu, 25 Mar 2021 19:29:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7A6133858001 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12PJTeSY028137 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 15:29:44 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12PJTeSY028137 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E21F41E789; Thu, 25 Mar 2021 15:29:39 -0400 (EDT) Subject: Re: [PATCH 1/2] Allow expand_symtabs_matching to examine imported psymtabs To: Tom Tromey , gdb-patches@sourceware.org References: <20210324201510.23655-1-tom@tromey.com> <20210324201510.23655-2-tom@tromey.com> Message-ID: <514da557-94e9-23c3-df1a-59ae42e32399@polymtl.ca> Date: Thu, 25 Mar 2021 15:29:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210324201510.23655-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 25 Mar 2021 19:29:40 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-24 4:15 p.m., Tom Tromey wrote: > Currently the psymtab variant of expand_symtabs_matching has this > check: > > /* We skip shared psymtabs because file-matching doesn't apply > to them; but we search them later in the loop. */ > if (ps->user != NULL) > continue; > > In a larger series I'm working on, it's convenient to remove this > check. And, I noticed that a similar check is not done for > expand_symtabs_with_fullname. So, it made sense to me to remove the > check here as well. > > gdb/ChangeLog > 2021-03-24 Tom Tromey > > * psymtab.c (psymbol_functions::expand_symtabs_matching): Remove > "user" check. > --- > gdb/ChangeLog | 5 +++++ > gdb/psymtab.c | 5 ----- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdb/psymtab.c b/gdb/psymtab.c > index 597817269c1..5a64166d983 100644 > --- a/gdb/psymtab.c > +++ b/gdb/psymtab.c > @@ -1313,11 +1313,6 @@ psymbol_functions::expand_symtabs_matching > if (ps->readin_p (objfile)) > continue; > > - /* We skip shared psymtabs because file-matching doesn't apply > - to them; but we search them later in the loop. */ > - if (ps->user != NULL) > - continue; > - > if (file_matcher) > { > bool match; > I'm not against this change, but I don't understand it. It seems logical to me to skip shared psymtabs, because we'll reach them through some other psymtabs that include them. So, both versions seem correct, but maybe knowing why it's convenient to you would help. Simon