Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Add watchpoint test with both condition and thread keywords
Date: Fri, 08 Mar 2013 19:08:00 -0000	[thread overview]
Message-ID: <513A3721.1050901@redhat.com> (raw)
In-Reply-To: <513A366D.9060600@redhat.com>

On 03/08/2013 07:05 PM, Keith Seitz wrote:
> On 03/08/2013 11:00 AM, Keith Seitz wrote:
> 
>> /me gets more coffee
> 
> I should have done this BEFORE I sent the "revised" patch. :-(
> 
> Sorry about that.

Not a problem at all.

> testsuite/ChangeLog
> 2013-03-08  Keith Seitz  <keiths@redhat.com>
> 
>     * watchpoint.exp (test_no_hw_watchpoints: Add test using

Missing ).

>     both condition and thread.  Then delete the watchpoint.
> 
> diff --git a/gdb/testsuite/gdb.base/watchpoint.exp b/gdb/testsuite/gdb.base/watchpoint.exp
> index 5086ae5..08a4a9a 100644
> --- a/gdb/testsuite/gdb.base/watchpoint.exp
> +++ b/gdb/testsuite/gdb.base/watchpoint.exp
> @@ -808,6 +808,12 @@ proc test_no_hw_watchpoints {} {
>      "Watchpoint \[0-9\]*: ival3.*" \
>      "set slow conditional watch"
> 
> +    gdb_test "watch ival3 if  count > 1  thread 1 " \
> +         "Watchpoint \[0-9\]*: ival3.*" \
> +         "set slow condition watch w/thread"
> +
> +    gdb_test_no_output "delete \$bpnum" "delete watch w/cond and thread"

This now deletes the same breakpoint twice.  $bpnum is the number of
the last breakpoint/watchpoint created.

> +
>      gdb_test "continue" \
>      "Watchpoint \[0-9\]*: ival3.*Old value = 1.*New value = 2.*" \
>      "trigger slow conditional watch"


-- 
Pedro Alves


  reply	other threads:[~2013-03-08 19:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 18:34 Keith Seitz
2013-03-08 18:45 ` Pedro Alves
2013-03-08 19:01   ` Keith Seitz
2013-03-08 19:05     ` Keith Seitz
2013-03-08 19:08       ` Pedro Alves [this message]
2013-03-08 19:24         ` Keith Seitz
2013-03-08 19:29           ` Pedro Alves
2013-03-11 19:03             ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513A3721.1050901@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox