Re: [RFA] Add watchpoint test with both condition and thread keywords

[Pedro Alves <palves@redhat.com>]

On 03/08/2013 06:34 PM, Keith Seitz wrote:

> 
> testsuite/ChangeLog
> 2013-03-08  Keith Seitz  <keiths@redhat.com>
> 
>     * watchpoint.exp: Add test using both condition and thread.

   * watchpoint.exp (test_no_hw_watchpoints): Add test using
   both condition and thread.

> 
> Index: testsuite/gdb.base/watchpoint.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/watchpoint.exp,v
> retrieving revision 1.61
> diff -u -p -r1.61 watchpoint.exp
> --- testsuite/gdb.base/watchpoint.exp    1 Jan 2013 06:33:26 -0000    1.61
> +++ testsuite/gdb.base/watchpoint.exp    8 Mar 2013 18:33:39 -0000
> @@ -808,6 +808,10 @@ proc test_no_hw_watchpoints {} {
>      "Watchpoint \[0-9\]*: ival3.*" \
>      "set slow conditional watch"
> 
> +    gdb_test "watch ival3 if  count > 1  thread 1 " \
> +         "Watchpoint \[0-9\]*: ival3.*" \
> +         "set slow condition watch w/thread"
> +

There's a test below that deletes the previous watchpoint.  But
now we have two.  Probably doesn't matter as gdb will exit soon,
but still, at least let's add a comment like "check we can
delete software watchpoints, no need to care to remove
them all." or some such.

>      gdb_test "continue" \
>      "Watchpoint \[0-9\]*: ival3.*Old value = 1.*New value = 2.*" \
>      "trigger slow conditional watch"

-- 
Pedro Alves