From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15813 invoked by alias); 8 Mar 2013 18:45:11 -0000 Received: (qmail 15801 invoked by uid 22791); 8 Mar 2013 18:45:09 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 18:44:51 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r28IipK5018842 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Mar 2013 13:44:51 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r28Iins4029344; Fri, 8 Mar 2013 13:44:50 -0500 Message-ID: <513A31A1.6000806@redhat.com> Date: Fri, 08 Mar 2013 18:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Keith Seitz CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] Add watchpoint test with both condition and thread keywords References: <513A2F18.8000402@redhat.com> In-Reply-To: <513A2F18.8000402@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00383.txt.bz2 On 03/08/2013 06:34 PM, Keith Seitz wrote: > > testsuite/ChangeLog > 2013-03-08 Keith Seitz > > * watchpoint.exp: Add test using both condition and thread. * watchpoint.exp (test_no_hw_watchpoints): Add test using both condition and thread. > > Index: testsuite/gdb.base/watchpoint.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/watchpoint.exp,v > retrieving revision 1.61 > diff -u -p -r1.61 watchpoint.exp > --- testsuite/gdb.base/watchpoint.exp 1 Jan 2013 06:33:26 -0000 1.61 > +++ testsuite/gdb.base/watchpoint.exp 8 Mar 2013 18:33:39 -0000 > @@ -808,6 +808,10 @@ proc test_no_hw_watchpoints {} { > "Watchpoint \[0-9\]*: ival3.*" \ > "set slow conditional watch" > > + gdb_test "watch ival3 if count > 1 thread 1 " \ > + "Watchpoint \[0-9\]*: ival3.*" \ > + "set slow condition watch w/thread" > + There's a test below that deletes the previous watchpoint. But now we have two. Probably doesn't matter as gdb will exit soon, but still, at least let's add a comment like "check we can delete software watchpoints, no need to care to remove them all." or some such. > gdb_test "continue" \ > "Watchpoint \[0-9\]*: ival3.*Old value = 1.*New value = 2.*" \ > "trigger slow conditional watch" -- Pedro Alves