Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: [RFA] Add watchpoint test with both condition and thread keywords
Date: Fri, 08 Mar 2013 18:34:00 -0000	[thread overview]
Message-ID: <513A2F18.8000402@redhat.com> (raw)

Hi,

While attempting to fix up my constify parse_exp_1 mini-patch, I 
discovered the branch of watch_command_1 which does "*tok = '\0';" (evil 
as it is) is completely untested.

So I'm adding one to aid my hacking.

Keith

testsuite/ChangeLog
2013-03-08  Keith Seitz  <keiths@redhat.com>

	* watchpoint.exp: Add test using both condition and thread.

Index: testsuite/gdb.base/watchpoint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/watchpoint.exp,v
retrieving revision 1.61
diff -u -p -r1.61 watchpoint.exp
--- testsuite/gdb.base/watchpoint.exp	1 Jan 2013 06:33:26 -0000	1.61
+++ testsuite/gdb.base/watchpoint.exp	8 Mar 2013 18:33:39 -0000
@@ -808,6 +808,10 @@ proc test_no_hw_watchpoints {} {
  	"Watchpoint \[0-9\]*: ival3.*" \
  	"set slow conditional watch"

+    gdb_test "watch ival3 if  count > 1  thread 1 " \
+         "Watchpoint \[0-9\]*: ival3.*" \
+         "set slow condition watch w/thread"
+
      gdb_test "continue" \
  	"Watchpoint \[0-9\]*: ival3.*Old value = 1.*New value = 2.*" \
  	"trigger slow conditional watch"


             reply	other threads:[~2013-03-08 18:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 18:34 Keith Seitz [this message]
2013-03-08 18:45 ` Pedro Alves
2013-03-08 19:01   ` Keith Seitz
2013-03-08 19:05     ` Keith Seitz
2013-03-08 19:08       ` Pedro Alves
2013-03-08 19:24         ` Keith Seitz
2013-03-08 19:29           ` Pedro Alves
2013-03-11 19:03             ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513A2F18.8000402@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox