From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3909 invoked by alias); 8 Mar 2013 18:34:15 -0000 Received: (qmail 3786 invoked by uid 22791); 8 Mar 2013 18:34:13 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 18:34:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r28IY1tw003497 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Mar 2013 13:34:01 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r28IY02B021359 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Fri, 8 Mar 2013 13:34:01 -0500 Message-ID: <513A2F18.8000402@redhat.com> Date: Fri, 08 Mar 2013 18:34:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: [RFA] Add watchpoint test with both condition and thread keywords Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00382.txt.bz2 Hi, While attempting to fix up my constify parse_exp_1 mini-patch, I discovered the branch of watch_command_1 which does "*tok = '\0';" (evil as it is) is completely untested. So I'm adding one to aid my hacking. Keith testsuite/ChangeLog 2013-03-08 Keith Seitz * watchpoint.exp: Add test using both condition and thread. Index: testsuite/gdb.base/watchpoint.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/watchpoint.exp,v retrieving revision 1.61 diff -u -p -r1.61 watchpoint.exp --- testsuite/gdb.base/watchpoint.exp 1 Jan 2013 06:33:26 -0000 1.61 +++ testsuite/gdb.base/watchpoint.exp 8 Mar 2013 18:33:39 -0000 @@ -808,6 +808,10 @@ proc test_no_hw_watchpoints {} { "Watchpoint \[0-9\]*: ival3.*" \ "set slow conditional watch" + gdb_test "watch ival3 if count > 1 thread 1 " \ + "Watchpoint \[0-9\]*: ival3.*" \ + "set slow condition watch w/thread" + gdb_test "continue" \ "Watchpoint \[0-9\]*: ival3.*Old value = 1.*New value = 2.*" \ "trigger slow conditional watch"