From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99310-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24272 invoked by alias); 8 Mar 2013 19:08:32 -0000
Received: (qmail 24219 invoked by uid 22791); 8 Mar 2013 19:08:30 -0000
X-SWARE-Spam-Status: No, hits=-8.0 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 19:08:19 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r28J8J1r032349	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 8 Mar 2013 14:08:19 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r28J8HRC000505;	Fri, 8 Mar 2013 14:08:18 -0500
Message-ID: <513A3721.1050901@redhat.com>
Date: Fri, 08 Mar 2013 19:08:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3
MIME-Version: 1.0
To: Keith Seitz <keiths@redhat.com>
CC: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Add watchpoint test with both condition and thread keywords
References: <513A2F18.8000402@redhat.com> <513A31A1.6000806@redhat.com> <513A3558.1090708@redhat.com> <513A366D.9060600@redhat.com>
In-Reply-To: <513A366D.9060600@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00386.txt.bz2

On 03/08/2013 07:05 PM, Keith Seitz wrote:
> On 03/08/2013 11:00 AM, Keith Seitz wrote:
> 
>> /me gets more coffee
> 
> I should have done this BEFORE I sent the "revised" patch. :-(
> 
> Sorry about that.

Not a problem at all.

> testsuite/ChangeLog
> 2013-03-08  Keith Seitz  <keiths@redhat.com>
> 
>     * watchpoint.exp (test_no_hw_watchpoints: Add test using

Missing ).

>     both condition and thread.  Then delete the watchpoint.
> 
> diff --git a/gdb/testsuite/gdb.base/watchpoint.exp b/gdb/testsuite/gdb.base/watchpoint.exp
> index 5086ae5..08a4a9a 100644
> --- a/gdb/testsuite/gdb.base/watchpoint.exp
> +++ b/gdb/testsuite/gdb.base/watchpoint.exp
> @@ -808,6 +808,12 @@ proc test_no_hw_watchpoints {} {
>      "Watchpoint \[0-9\]*: ival3.*" \
>      "set slow conditional watch"
> 
> +    gdb_test "watch ival3 if  count > 1  thread 1 " \
> +         "Watchpoint \[0-9\]*: ival3.*" \
> +         "set slow condition watch w/thread"
> +
> +    gdb_test_no_output "delete \$bpnum" "delete watch w/cond and thread"

This now deletes the same breakpoint twice.  $bpnum is the number of
the last breakpoint/watchpoint created.

> +
>      gdb_test "continue" \
>      "Watchpoint \[0-9\]*: ival3.*Old value = 1.*New value = 2.*" \
>      "trigger slow conditional watch"


-- 
Pedro Alves