Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't need fast tracepoint in tstatus.exp
Date: Tue, 05 Mar 2013 13:08:00 -0000	[thread overview]
Message-ID: <5135EE39.3050904@redhat.com> (raw)
In-Reply-To: <513579D4.6040000@codesourcery.com>

On 03/05/2013 04:51 AM, Yao Qi wrote:
> On 03/05/2013 12:46 AM, Pedro Alves wrote:
>>> tstatus.exp is used to test the output of 'tstatus' but there are some
>>>> tests on fast tracepoint in it, which is not related to tstatus.  This
>>>> patch is to remove these fast tracepoint related stuff from tstatus.exp.
>> Can we assume
>>
> 

I actually meant to delete that, sorry.

> The reason why fast tracepoint stuff was added into tstatus.exp is
> unclear to me.  It was not mentioned in the mail posting this patch.

Did you ask Stan?

>   However, I can't see how fast tracepoint affects the output of 
> 'tstatus', so I propose this patch to remove them.
> 
>> If we aren't doing any fast tracepoint tests, then is
>> there a reason to keep this prepare_for_testing and
>> runto_main instead of removing them altogether?
> 
> OK, the prepare_for_testing and runto_main are removed.

> 2013-03-05  Yao Qi  <yao@codesourcery.com>
>
> 	* gdb.trace/tstatus.exp: Remove the invocation to
> 	gdb_load_shlibs, gdb_compile, clean_restart and runto_main.

"invocation of"

> 	(test_tracepoints): Don't set fast tracepoint.
> 	(top level): Don't check agent library is loaded or not.

OK.

-- 
Pedro Alves


  reply	other threads:[~2013-03-05 13:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 15:47 Yao Qi
2013-03-04 16:47 ` Pedro Alves
2013-03-05  4:52   ` Yao Qi
2013-03-05 13:08     ` Pedro Alves [this message]
2013-03-06  0:11 ` Stan Shebs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5135EE39.3050904@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox