From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30262 invoked by alias); 5 Mar 2013 13:08:21 -0000 Received: (qmail 29943 invoked by uid 22791); 5 Mar 2013 13:08:18 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 13:08:12 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r25D8Bbc021312 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Mar 2013 08:08:11 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r25D8ADF012812; Tue, 5 Mar 2013 08:08:10 -0500 Message-ID: <5135EE39.3050904@redhat.com> Date: Tue, 05 Mar 2013 13:08:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Don't need fast tracepoint in tstatus.exp References: <1362412004-23628-1-git-send-email-yao@codesourcery.com> <5134CFEC.7070902@redhat.com> <513579D4.6040000@codesourcery.com> In-Reply-To: <513579D4.6040000@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00145.txt.bz2 On 03/05/2013 04:51 AM, Yao Qi wrote: > On 03/05/2013 12:46 AM, Pedro Alves wrote: >>> tstatus.exp is used to test the output of 'tstatus' but there are some >>>> tests on fast tracepoint in it, which is not related to tstatus. This >>>> patch is to remove these fast tracepoint related stuff from tstatus.exp. >> Can we assume >> > I actually meant to delete that, sorry. > The reason why fast tracepoint stuff was added into tstatus.exp is > unclear to me. It was not mentioned in the mail posting this patch. Did you ask Stan? > However, I can't see how fast tracepoint affects the output of > 'tstatus', so I propose this patch to remove them. > >> If we aren't doing any fast tracepoint tests, then is >> there a reason to keep this prepare_for_testing and >> runto_main instead of removing them altogether? > > OK, the prepare_for_testing and runto_main are removed. > 2013-03-05 Yao Qi > > * gdb.trace/tstatus.exp: Remove the invocation to > gdb_load_shlibs, gdb_compile, clean_restart and runto_main. "invocation of" > (test_tracepoints): Don't set fast tracepoint. > (top level): Don't check agent library is loaded or not. OK. -- Pedro Alves