Re: [PATCH] Don't need fast tracepoint in tstatus.exp

[Pedro Alves <palves@redhat.com>]

On 03/04/2013 03:46 PM, Yao Qi wrote:
> tstatus.exp is used to test the output of 'tstatus' but there are some
> tests on fast tracepoint in it, which is not related to tstatus.  This
> patch is to remove these fast tracepoint related stuff from tstatus.exp.

Can we assume

> 
> gdb/testsuite:
> 
> 2013-03-04  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.trace/tstatus.exp: Use prepare_for_testing.
> 	(test_tracepoints): Don't set fast tracepoint.
> 	(top level): Don't check agent library is loaded or not.
> ---
>  gdb/testsuite/gdb.trace/tstatus.exp |   41 +++-------------------------------
>  1 files changed, 4 insertions(+), 37 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.trace/tstatus.exp b/gdb/testsuite/gdb.trace/tstatus.exp
> index 8a0bbdf..483bb20 100644
> --- a/gdb/testsuite/gdb.trace/tstatus.exp
> +++ b/gdb/testsuite/gdb.trace/tstatus.exp
> @@ -34,22 +34,14 @@ if ![gdb_target_supports_trace] {
>      return -1
>  }
>  
> -set libipa [get_in_proc_agent]
> -gdb_load_shlibs $libipa
> -
> -# Can't use prepare_for_testing, because that splits compiling into
> -# building objects and then linking, and we'd fail with "linker input
> -# file unused because linking not done" when building the object.
> -
> -if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
> -	  executable [list debug shlib=$libipa] ] != "" } {
> -    untested "failed to compile ftrace tests"
> +if [prepare_for_testing $expfile $executable $srcfile \
> +	{debug nowarnings} ] {
> +    untested "failed to compile tracepoint tests"
>      return -1
>  }
> -clean_restart ${executable}
>  
>  if ![runto_main] {
> -    fail "Can't run to main for ftrace tests"
> +    fail "Can't run to main for tracepoint tests"
>      return 0
>  }

If we aren't doing any fast tracepoint tests, then is
there a reason to keep this prepare_for_testing and
runto_main instead of removing them altogether?

-- 
Pedro Alves