From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4038 invoked by alias); 4 Mar 2013 16:47:18 -0000 Received: (qmail 4026 invoked by uid 22791); 4 Mar 2013 16:47:13 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Mar 2013 16:46:40 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r24GkcM7011033 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 4 Mar 2013 11:46:38 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r24GkaA6027644; Mon, 4 Mar 2013 11:46:37 -0500 Message-ID: <5134CFEC.7070902@redhat.com> Date: Mon, 04 Mar 2013 16:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Don't need fast tracepoint in tstatus.exp References: <1362412004-23628-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1362412004-23628-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00094.txt.bz2 On 03/04/2013 03:46 PM, Yao Qi wrote: > tstatus.exp is used to test the output of 'tstatus' but there are some > tests on fast tracepoint in it, which is not related to tstatus. This > patch is to remove these fast tracepoint related stuff from tstatus.exp. Can we assume > > gdb/testsuite: > > 2013-03-04 Yao Qi > > * gdb.trace/tstatus.exp: Use prepare_for_testing. > (test_tracepoints): Don't set fast tracepoint. > (top level): Don't check agent library is loaded or not. > --- > gdb/testsuite/gdb.trace/tstatus.exp | 41 +++------------------------------- > 1 files changed, 4 insertions(+), 37 deletions(-) > > diff --git a/gdb/testsuite/gdb.trace/tstatus.exp b/gdb/testsuite/gdb.trace/tstatus.exp > index 8a0bbdf..483bb20 100644 > --- a/gdb/testsuite/gdb.trace/tstatus.exp > +++ b/gdb/testsuite/gdb.trace/tstatus.exp > @@ -34,22 +34,14 @@ if ![gdb_target_supports_trace] { > return -1 > } > > -set libipa [get_in_proc_agent] > -gdb_load_shlibs $libipa > - > -# Can't use prepare_for_testing, because that splits compiling into > -# building objects and then linking, and we'd fail with "linker input > -# file unused because linking not done" when building the object. > - > -if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ > - executable [list debug shlib=$libipa] ] != "" } { > - untested "failed to compile ftrace tests" > +if [prepare_for_testing $expfile $executable $srcfile \ > + {debug nowarnings} ] { > + untested "failed to compile tracepoint tests" > return -1 > } > -clean_restart ${executable} > > if ![runto_main] { > - fail "Can't run to main for ftrace tests" > + fail "Can't run to main for tracepoint tests" > return 0 > } If we aren't doing any fast tracepoint tests, then is there a reason to keep this prepare_for_testing and runto_main instead of removing them altogether? -- Pedro Alves