From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Don't need fast tracepoint in tstatus.exp
Date: Mon, 04 Mar 2013 15:47:00 -0000 [thread overview]
Message-ID: <1362412004-23628-1-git-send-email-yao@codesourcery.com> (raw)
tstatus.exp is used to test the output of 'tstatus' but there are some
tests on fast tracepoint in it, which is not related to tstatus. This
patch is to remove these fast tracepoint related stuff from tstatus.exp.
gdb/testsuite:
2013-03-04 Yao Qi <yao@codesourcery.com>
* gdb.trace/tstatus.exp: Use prepare_for_testing.
(test_tracepoints): Don't set fast tracepoint.
(top level): Don't check agent library is loaded or not.
---
gdb/testsuite/gdb.trace/tstatus.exp | 41 +++-------------------------------
1 files changed, 4 insertions(+), 37 deletions(-)
diff --git a/gdb/testsuite/gdb.trace/tstatus.exp b/gdb/testsuite/gdb.trace/tstatus.exp
index 8a0bbdf..483bb20 100644
--- a/gdb/testsuite/gdb.trace/tstatus.exp
+++ b/gdb/testsuite/gdb.trace/tstatus.exp
@@ -34,22 +34,14 @@ if ![gdb_target_supports_trace] {
return -1
}
-set libipa [get_in_proc_agent]
-gdb_load_shlibs $libipa
-
-# Can't use prepare_for_testing, because that splits compiling into
-# building objects and then linking, and we'd fail with "linker input
-# file unused because linking not done" when building the object.
-
-if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
- executable [list debug shlib=$libipa] ] != "" } {
- untested "failed to compile ftrace tests"
+if [prepare_for_testing $expfile $executable $srcfile \
+ {debug nowarnings} ] {
+ untested "failed to compile tracepoint tests"
return -1
}
-clean_restart ${executable}
if ![runto_main] {
- fail "Can't run to main for ftrace tests"
+ fail "Can't run to main for tracepoint tests"
return 0
}
@@ -141,34 +133,9 @@ proc test_tracepoints {} {
gdb_trace_setactions "collect at set_point: define actions" \
"" \
"collect parm" "^$"
- set fastgood 0
-
- gdb_test_multiple "ftrace gdb_recursion_test" "set fast tracepoint" {
- -re "May not have a fast tracepoint at .*\r\n$gdb_prompt $" {
- pass "4-byte fast tracepoint could not be set"
- }
- -re "Fast tracepoint .*\r\n$gdb_prompt $" {
- pass "4-byte fast tracepoint is set"
- set fastgood 1
- }
- }
-
- if { $fastgood } {
-
- gdb_trace_setactions "collect at four_byter: define actions" \
- "" \
- "collect globvar, anarg" "^$"
- }
run_trace_experiment
}
-gdb_reinitialize_dir $srcdir/$subdir
-
-if { [gdb_test "info sharedlibrary" ".*${libipa}.*" "IPA loaded"] != 0 } {
- untested "Could not find IPA lib loaded"
- return 1
-}
-
test_tracepoints
--
1.7.7.6
next reply other threads:[~2013-03-04 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 15:47 Yao Qi [this message]
2013-03-04 16:47 ` Pedro Alves
2013-03-05 4:52 ` Yao Qi
2013-03-05 13:08 ` Pedro Alves
2013-03-06 0:11 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362412004-23628-1-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox