From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "Abid, Hafiz" <hafiz_abid@mentor.com>,
gdb-patches@sourceware.org, marc.khouzam@ericsson.com
Subject: Re: [Patch] Get trace file name when using 'target tfile'
Date: Thu, 14 Feb 2013 14:34:00 -0000 [thread overview]
Message-ID: <511CF5E7.1090600@redhat.com> (raw)
In-Reply-To: <511C56FE.7000503@codesourcery.com>
On 02/14/2013 03:16 AM, Yao Qi wrote:
> On 02/13/2013 10:38 PM, Abid, Hafiz wrote:
>> - /* This is true if the status is coming from a file rather
>> - than a live target. */
>> - int from_file;
>> + /* If the status is coming from a file rather than a live target,
>> + this points at the file's filename. Otherwise, this is NULL. */
>> + const char *from_file;
>
> How about rename this field to "trace_filename", or something similar? "from_file" is fine as a boolean, but is confusing as a the name of trace file.
Fine with me. I'd drop the "trace_" bit as being redundant
with "struct trace_status".
--
Pedro Alves
next prev parent reply other threads:[~2013-02-14 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 14:38 Abid, Hafiz
2013-02-13 16:34 ` Pedro Alves
2013-02-13 17:59 ` Eli Zaretskii
2013-02-14 3:17 ` Yao Qi
2013-02-14 14:34 ` Pedro Alves [this message]
2013-02-14 15:49 ` Abid, Hafiz
2013-02-14 15:57 ` Pedro Alves
2013-02-14 22:02 ` Eli Zaretskii
2013-02-15 10:15 ` Abid, Hafiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511CF5E7.1090600@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hafiz_abid@mentor.com \
--cc=marc.khouzam@ericsson.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox