Re: [Patch] Get trace file name when using 'target tfile'

[Pedro Alves <palves@redhat.com>]

On 02/13/2013 02:38 PM, Abid, Hafiz wrote:

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index e3f336e..e8ac8c5 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -32094,6 +32094,10 @@ The value of the disconnected tracing flag.  @code{1} means that
>  tracing will continue after @value{GDBN} disconnects, @code{0} means
>  that the trace run will stop.
>  
> +@item trace-file
> +The filename of the trace file being examined.  This field is
> +optional, and only present when examining a trace file.

The docs bits need Eli's approval.  Obviously it looks
good to me. :-)  Though, since this adds an MI attribute, it
should have a corresponding NEWS entry too.

I'd be good to tweak the MI tfile tests to check this new field.
Can you do that please?

> +  if (ts->from_file)

  if (ts->from_file != NULL)

> +    ui_out_field_string (uiout, "trace-file", ts->from_file);


> +  /* We know we're working with a file. Record its name.  */

Double space. ----------------------------^

Otherwise this is OK.

-- 
Pedro Alves