Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Abid, Hafiz" <hafiz_abid@mentor.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: <palves@redhat.com>, <yao@codesourcery.com>,
	<gdb-patches@sourceware.org>,	<marc.khouzam@ericsson.com>
Subject: Re: [Patch] Get trace file name when using 'target tfile'
Date: Fri, 15 Feb 2013 10:15:00 -0000	[thread overview]
Message-ID: <1360923315.2842.5@abidh-ubunto1104> (raw)
In-Reply-To: <83r4kituze.fsf@gnu.org> (from eliz@gnu.org on Thu Feb 14	22:02:13 2013)

On 14/02/13 22:02:13, Eli Zaretskii wrote:
> > Date: Thu, 14 Feb 2013 15:49:30 +0000
> > From: "Abid, Hafiz" <hafiz_abid@mentor.com>
> > CC: Yao Qi <yao@codesourcery.com>, <gdb-patches@sourceware.org>,
> > 	<marc.khouzam@ericsson.com>
> >
> > 1. Renamed "from_file" field to "filename". Use explicit NULL(or
> > non-NULL) check against it.
> > 2. Added a test case for -trace-struct command.
> > 3. Added NEWS entry.
> >
> > How does it look?
> 
> OK, but:
> 
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -150,6 +150,9 @@ show filename-display
> >    ** The response to breakpoint commands and breakpoint async  
> records
> >       includes an "installed" field containing a boolean state  
> about each
> >       non-pending tracepoint location is whether installed on  
> target or not.
> > +  ** Output of the "-trace-status" command includes a "trace-file"  
> field
> > +     containing the name of the trace file being examined. This  
> field is
>                                                             ^^
> Two spaces between sentences, please.
> 
> The documentation parts are OK with that change.  Thanks.
> 

Thanks Eli and Pedro for review. I committed after making the change  
suggested by Eli.

Regards,
Abid


      reply	other threads:[~2013-02-15 10:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 14:38 Abid, Hafiz
2013-02-13 16:34 ` Pedro Alves
2013-02-13 17:59 ` Eli Zaretskii
2013-02-14  3:17 ` Yao Qi
2013-02-14 14:34   ` Pedro Alves
2013-02-14 15:49     ` Abid, Hafiz
2013-02-14 15:57       ` Pedro Alves
2013-02-14 22:02       ` Eli Zaretskii
2013-02-15 10:15         ` Abid, Hafiz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360923315.2842.5@abidh-ubunto1104 \
    --to=hafiz_abid@mentor.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    --cc=palves@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox