From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28831 invoked by alias); 15 Feb 2013 10:15:31 -0000 Received: (qmail 28815 invoked by uid 22791); 15 Feb 2013 10:15:29 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Feb 2013 10:15:20 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1U6IK6-0005pK-LR from Hafiz_Abid@mentor.com ; Fri, 15 Feb 2013 02:15:18 -0800 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 15 Feb 2013 02:15:18 -0800 Received: from abidh-ubunto1104 (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server (TLS) id 14.1.289.1; Fri, 15 Feb 2013 10:15:17 +0000 Date: Fri, 15 Feb 2013 10:15:00 -0000 From: "Abid, Hafiz" Subject: Re: [Patch] Get trace file name when using 'target tfile' To: Eli Zaretskii CC: , , , References: <1360856970.2842.4@abidh-ubunto1104> <83r4kituze.fsf@gnu.org> In-Reply-To: <83r4kituze.fsf@gnu.org> (from eliz@gnu.org on Thu Feb 14 22:02:13 2013) Message-ID: <1360923315.2842.5@abidh-ubunto1104> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00386.txt.bz2 On 14/02/13 22:02:13, Eli Zaretskii wrote: > > Date: Thu, 14 Feb 2013 15:49:30 +0000 > > From: "Abid, Hafiz" > > CC: Yao Qi , , > > > > > > 1. Renamed "from_file" field to "filename". Use explicit NULL(or > > non-NULL) check against it. > > 2. Added a test case for -trace-struct command. > > 3. Added NEWS entry. > > > > How does it look? >=20 > OK, but: >=20 > > --- a/gdb/NEWS > > +++ b/gdb/NEWS > > @@ -150,6 +150,9 @@ show filename-display > > ** The response to breakpoint commands and breakpoint async=20=20 > records > > includes an "installed" field containing a boolean state=20=20 > about each > > non-pending tracepoint location is whether installed on=20=20 > target or not. > > + ** Output of the "-trace-status" command includes a "trace-file"=20= =20 > field > > + containing the name of the trace file being examined. This=20=20 > field is > ^^ > Two spaces between sentences, please. >=20 > The documentation parts are OK with that change. Thanks. >=20 Thanks Eli and Pedro for review. I committed after making the change=20=20 suggested by Eli. Regards, Abid