From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15725 invoked by alias); 13 Feb 2013 16:34:43 -0000 Received: (qmail 15561 invoked by uid 22791); 13 Feb 2013 16:34:41 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Feb 2013 16:34:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1DGYDJL004839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Feb 2013 11:34:13 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1DGYB6P007916; Wed, 13 Feb 2013 11:34:12 -0500 Message-ID: <511BC083.2050803@redhat.com> Date: Wed, 13 Feb 2013 16:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: "Abid, Hafiz" CC: gdb-patches@sourceware.org, marc.khouzam@ericsson.com Subject: Re: [Patch] Get trace file name when using 'target tfile' References: <1360766298.2842.0@abidh-ubunto1104> In-Reply-To: <1360766298.2842.0@abidh-ubunto1104> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00312.txt.bz2 On 02/13/2013 02:38 PM, Abid, Hafiz wrote: > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index e3f336e..e8ac8c5 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -32094,6 +32094,10 @@ The value of the disconnected tracing flag. @code{1} means that > tracing will continue after @value{GDBN} disconnects, @code{0} means > that the trace run will stop. > > +@item trace-file > +The filename of the trace file being examined. This field is > +optional, and only present when examining a trace file. The docs bits need Eli's approval. Obviously it looks good to me. :-) Though, since this adds an MI attribute, it should have a corresponding NEWS entry too. I'd be good to tweak the MI tfile tests to check this new field. Can you do that please? > + if (ts->from_file) if (ts->from_file != NULL) > + ui_out_field_string (uiout, "trace-file", ts->from_file); > + /* We know we're working with a file. Record its name. */ Double space. ----------------------------^ Otherwise this is OK. -- Pedro Alves