From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5827 invoked by alias); 14 Feb 2013 14:34:48 -0000 Received: (qmail 5805 invoked by uid 22791); 14 Feb 2013 14:34:45 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 14:34:24 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1EEYIih012051 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Feb 2013 09:34:18 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1EEYGkC017433; Thu, 14 Feb 2013 09:34:17 -0500 Message-ID: <511CF5E7.1090600@redhat.com> Date: Thu, 14 Feb 2013 14:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Yao Qi CC: "Abid, Hafiz" , gdb-patches@sourceware.org, marc.khouzam@ericsson.com Subject: Re: [Patch] Get trace file name when using 'target tfile' References: <1360766298.2842.0@abidh-ubunto1104> <511C56FE.7000503@codesourcery.com> In-Reply-To: <511C56FE.7000503@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00346.txt.bz2 On 02/14/2013 03:16 AM, Yao Qi wrote: > On 02/13/2013 10:38 PM, Abid, Hafiz wrote: >> - /* This is true if the status is coming from a file rather >> - than a live target. */ >> - int from_file; >> + /* If the status is coming from a file rather than a live target, >> + this points at the file's filename. Otherwise, this is NULL. */ >> + const char *from_file; > > How about rename this field to "trace_filename", or something similar? "from_file" is fine as a boolean, but is confusing as a the name of trace file. Fine with me. I'd drop the "trace_" bit as being redundant with "struct trace_status". -- Pedro Alves