* RFC: fix race in py-explore.exp
@ 2013-01-14 19:24 Tom Tromey
2013-01-15 14:56 ` Pedro Alves
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tom Tromey @ 2013-01-14 19:24 UTC (permalink / raw)
To: gdb-patches
I had py-explore.exp spuriously fail on me.
I think it needs to expect the prompt in this spot.
I'm not totally sure about this, comments requested.
Built and regtested on x86-64 Fedora 16.
Tom
* gdb.python/py-explore.exp: Expect the gdb prompt.
---
gdb/testsuite/gdb.python/py-explore.exp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gdb/testsuite/gdb.python/py-explore.exp b/gdb/testsuite/gdb.python/py-explore.exp
index 0fb67d3..bc4446d 100644
--- a/gdb/testsuite/gdb.python/py-explore.exp
+++ b/gdb/testsuite/gdb.python/py-explore.exp
@@ -96,7 +96,7 @@ gdb_test_multiple "explore ss_ptr" "" {
-re "[pointer_description {ss_ptr} $SS].*" {
pass "explore ss_ptr"
gdb_test_multiple "y" "explore_as_single_value_pointer" {
- -re "$SS_fields" {
+ -re "$SS_fields.*$gdb_prompt" {
pass "explore ss_ptr as single value pointer"
}
}
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: RFC: fix race in py-explore.exp
2013-01-14 19:24 RFC: fix race in py-explore.exp Tom Tromey
@ 2013-01-15 14:56 ` Pedro Alves
2013-01-20 10:43 ` Siva Chandra
2013-01-25 17:59 ` Tom Tromey
2 siblings, 0 replies; 6+ messages in thread
From: Pedro Alves @ 2013-01-15 14:56 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 01/14/2013 07:24 PM, Tom Tromey wrote:
> I had py-explore.exp spuriously fail on me.
>
> I think it needs to expect the prompt in this spot.
> I'm not totally sure about this, comments requested.
Looks right to me. Jan's read1 hack makes this
100% reproducible.
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: fix race in py-explore.exp
2013-01-14 19:24 RFC: fix race in py-explore.exp Tom Tromey
2013-01-15 14:56 ` Pedro Alves
@ 2013-01-20 10:43 ` Siva Chandra
2013-01-21 15:15 ` Tom Tromey
2013-01-25 17:59 ` Tom Tromey
2 siblings, 1 reply; 6+ messages in thread
From: Siva Chandra @ 2013-01-20 10:43 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On Mon, Jan 14, 2013 at 11:24 AM, Tom Tromey <tromey@redhat.com> wrote:
> I had py-explore.exp spuriously fail on me.
>
> I think it needs to expect the prompt in this spot.
> I'm not totally sure about this, comments requested.
How do we reproduce this failure? I am not seeing this on my side with head.
> Built and regtested on x86-64 Fedora 16.
>
> Tom
>
> * gdb.python/py-explore.exp: Expect the gdb prompt.
> ---
> gdb/testsuite/gdb.python/py-explore.exp | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.python/py-explore.exp b/gdb/testsuite/gdb.python/py-explore.exp
> index 0fb67d3..bc4446d 100644
> --- a/gdb/testsuite/gdb.python/py-explore.exp
> +++ b/gdb/testsuite/gdb.python/py-explore.exp
> @@ -96,7 +96,7 @@ gdb_test_multiple "explore ss_ptr" "" {
> -re "[pointer_description {ss_ptr} $SS].*" {
> pass "explore ss_ptr"
> gdb_test_multiple "y" "explore_as_single_value_pointer" {
> - -re "$SS_fields" {
> + -re "$SS_fields.*$gdb_prompt" {
> pass "explore ss_ptr as single value pointer"
> }
> }
> --
> 1.7.7.6
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: RFC: fix race in py-explore.exp
2013-01-20 10:43 ` Siva Chandra
@ 2013-01-21 15:15 ` Tom Tromey
2013-01-28 18:16 ` Doug Evans
0 siblings, 1 reply; 6+ messages in thread
From: Tom Tromey @ 2013-01-21 15:15 UTC (permalink / raw)
To: Siva Chandra; +Cc: gdb-patches
>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
Siva> How do we reproduce this failure? I am not seeing this on my side
Siva> with head.
I only saw it intermittently.
Pedro reports you can see it using the "read1" program, see
http://sourceware.org/bugzilla/show_bug.cgi?id=12649
I didn't try that yet.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: fix race in py-explore.exp
2013-01-21 15:15 ` Tom Tromey
@ 2013-01-28 18:16 ` Doug Evans
0 siblings, 0 replies; 6+ messages in thread
From: Doug Evans @ 2013-01-28 18:16 UTC (permalink / raw)
To: Tom Tromey; +Cc: Siva Chandra, gdb-patches, Jan Kratochvil
On Mon, Jan 21, 2013 at 6:56 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
>
> Siva> How do we reproduce this failure? I am not seeing this on my side
> Siva> with head.
>
> I only saw it intermittently.
> Pedro reports you can see it using the "read1" program, see
> http://sourceware.org/bugzilla/show_bug.cgi?id=12649
> I didn't try that yet.
An excellent thing to add to testsuite/contrib or some such, so it's
always Just There, and one doesn't have to go looking.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: fix race in py-explore.exp
2013-01-14 19:24 RFC: fix race in py-explore.exp Tom Tromey
2013-01-15 14:56 ` Pedro Alves
2013-01-20 10:43 ` Siva Chandra
@ 2013-01-25 17:59 ` Tom Tromey
2 siblings, 0 replies; 6+ messages in thread
From: Tom Tromey @ 2013-01-25 17:59 UTC (permalink / raw)
To: gdb-patches
>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
Tom> * gdb.python/py-explore.exp: Expect the gdb prompt.
I'm checking this in now.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-28 18:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-14 19:24 RFC: fix race in py-explore.exp Tom Tromey
2013-01-15 14:56 ` Pedro Alves
2013-01-20 10:43 ` Siva Chandra
2013-01-21 15:15 ` Tom Tromey
2013-01-28 18:16 ` Doug Evans
2013-01-25 17:59 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox