From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29711 invoked by alias); 20 Jan 2013 10:43:33 -0000 Received: (qmail 29702 invoked by uid 22791); 20 Jan 2013 10:43:32 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ee0-f41.google.com (HELO mail-ee0-f41.google.com) (74.125.83.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 20 Jan 2013 10:43:26 +0000 Received: by mail-ee0-f41.google.com with SMTP id c13so2471814eek.28 for ; Sun, 20 Jan 2013 02:43:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=XWuz/PUlaswkX5uOI+njp+GRAtxmuTtgTjBcDoCkH0U=; b=Ikmyjty6COgDPNs2XUA+ioXrAZgr4xqL2hNVnbua26aKZysyio563AsqYTvZ0PhQn+ 4FVyut7BrwpJohmLF1vNt5jkpVN1KAemPbN9xtY6h+YtzJUN6nzUgv8814p34KtnmjIK rYpgmdh7DYLCwSwVmrbAAaMvIGlTa5ESOBYSAyNx2neEkF/UsAUi3bWXaLPNXELtGgpI Wae/MPyu5jgnER8dS7hlpd3ckUyAQydJukJ7A0wffDnUgPpnGQCIJCh7rPiPvEl4IHZg 7NdtLr1AHVDC7dRUP9vu1xVyWFB1Bq+d7C3uOCUnWBYgSc6dM5Y2/dXFFA7z0IHlXY/u 8tng== MIME-Version: 1.0 X-Received: by 10.14.177.1 with SMTP id c1mr47536089eem.8.1358678605300; Sun, 20 Jan 2013 02:43:25 -0800 (PST) Received: by 10.14.205.196 with HTTP; Sun, 20 Jan 2013 02:43:25 -0800 (PST) In-Reply-To: <87vcazo9ed.fsf@fleche.redhat.com> References: <87vcazo9ed.fsf@fleche.redhat.com> Date: Sun, 20 Jan 2013 10:43:00 -0000 Message-ID: Subject: Re: RFC: fix race in py-explore.exp From: Siva Chandra To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlBd5XOl7oLBYhAm9ChWnDWse3uVNTXHxXIN+dKa+AK8l7xS5xxdT1UdBf3f3zrRo1jVFl6giaX+Hgphrc9v7cinizCLa2rhtqWyQNCWC2UpcB0Z4j2ppdrQd8UQNqfqm8fD1ZG2Qz/XM9C3n7hA7OpkoBzG6trk4D1Feq6yriMDX+eS4ByyQi3uRBD2Fl36jlTMsSKckucdNUBWkBLBFNhpWZKwg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00470.txt.bz2 On Mon, Jan 14, 2013 at 11:24 AM, Tom Tromey wrote: > I had py-explore.exp spuriously fail on me. > > I think it needs to expect the prompt in this spot. > I'm not totally sure about this, comments requested. How do we reproduce this failure? I am not seeing this on my side with head. > Built and regtested on x86-64 Fedora 16. > > Tom > > * gdb.python/py-explore.exp: Expect the gdb prompt. > --- > gdb/testsuite/gdb.python/py-explore.exp | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gdb/testsuite/gdb.python/py-explore.exp b/gdb/testsuite/gdb.python/py-explore.exp > index 0fb67d3..bc4446d 100644 > --- a/gdb/testsuite/gdb.python/py-explore.exp > +++ b/gdb/testsuite/gdb.python/py-explore.exp > @@ -96,7 +96,7 @@ gdb_test_multiple "explore ss_ptr" "" { > -re "[pointer_description {ss_ptr} $SS].*" { > pass "explore ss_ptr" > gdb_test_multiple "y" "explore_as_single_value_pointer" { > - -re "$SS_fields" { > + -re "$SS_fields.*$gdb_prompt" { > pass "explore ss_ptr as single value pointer" > } > } > -- > 1.7.7.6 >