From: Siva Chandra <sivachandra@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix race in py-explore.exp
Date: Sun, 20 Jan 2013 10:43:00 -0000 [thread overview]
Message-ID: <CAGyQ6gyNPe2SGeM_4qvJsH+XtrsnQ-15zcqrWyeA=ZTKBAsDTQ@mail.gmail.com> (raw)
In-Reply-To: <87vcazo9ed.fsf@fleche.redhat.com>
On Mon, Jan 14, 2013 at 11:24 AM, Tom Tromey <tromey@redhat.com> wrote:
> I had py-explore.exp spuriously fail on me.
>
> I think it needs to expect the prompt in this spot.
> I'm not totally sure about this, comments requested.
How do we reproduce this failure? I am not seeing this on my side with head.
> Built and regtested on x86-64 Fedora 16.
>
> Tom
>
> * gdb.python/py-explore.exp: Expect the gdb prompt.
> ---
> gdb/testsuite/gdb.python/py-explore.exp | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.python/py-explore.exp b/gdb/testsuite/gdb.python/py-explore.exp
> index 0fb67d3..bc4446d 100644
> --- a/gdb/testsuite/gdb.python/py-explore.exp
> +++ b/gdb/testsuite/gdb.python/py-explore.exp
> @@ -96,7 +96,7 @@ gdb_test_multiple "explore ss_ptr" "" {
> -re "[pointer_description {ss_ptr} $SS].*" {
> pass "explore ss_ptr"
> gdb_test_multiple "y" "explore_as_single_value_pointer" {
> - -re "$SS_fields" {
> + -re "$SS_fields.*$gdb_prompt" {
> pass "explore ss_ptr as single value pointer"
> }
> }
> --
> 1.7.7.6
>
next prev parent reply other threads:[~2013-01-20 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 19:24 Tom Tromey
2013-01-15 14:56 ` Pedro Alves
2013-01-20 10:43 ` Siva Chandra [this message]
2013-01-21 15:15 ` Tom Tromey
2013-01-28 18:16 ` Doug Evans
2013-01-25 17:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGyQ6gyNPe2SGeM_4qvJsH+XtrsnQ-15zcqrWyeA=ZTKBAsDTQ@mail.gmail.com' \
--to=sivachandra@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox