From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/8] de-couple %Stop from notification: gdb
Date: Wed, 12 Dec 2012 17:32:00 -0000 [thread overview]
Message-ID: <50C8BFB2.2050400@redhat.com> (raw)
In-Reply-To: <1355208017-9204-4-git-send-email-yao@codesourcery.com>
On 12/11/2012 06:40 AM, Yao Qi wrote:
> 2012-12-11 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in (REMOTE_OBS): Add "remote-notif.o".
> (SFILES): Add "remote-notif.c".
> (HFILES_NO_SRCDIR): Add "remote-notif.h" and "common/queue.h".
> * remote-notif.c: New. Factored out from remote.c.
> * remote-notif.h: New.
> * remote.c: Include "remote-notif.h".
> (stop_reply_xmalloc, do_stop_reply_xfree):
> (remote_parse_stop_reply, remote_get_pending_stop_replies):
> (remote_async_get_pending_events_handler): Remove declarations.
> (remote_parse_stop_reply): Declare.
> (pending_stop_reply): Remove.
> (remote_async_get_pending_events_token): Move to
> remote-notif.c.
> (remote_close): Replace 'delete_async_event_handler' with
> remote_notif_unregister_async_event_handler.
> Don't call discard_pending_stop_replies.
> (remote_start_remote): Replace code with remote_notif_parse
> and remote_notif_get_pending_replies.
> (remote_open_1): Replace 'create_async_event_handler' with
> remote_notif_register_async_event_handler.
> (extended_remote_attach_1): Call remote_notif_parse and
> notif_stop_reply_push.
> (struct stop_reply) <next>: Remove.
> <base>: New field.
> Callers update.
> (stop_reply_queue): Change its type.
> (stop_reply_xmalloc, do_stop_reply_xfree): Remove.
> (remote_notif_remove_all): New.
> (discard_pending_stop_replies): Update.
> (remote_notif_stop_ack, stop_reply_dtr): New.
> (remote_notif_stop_alloc_event): New.
> (notif_client_stop): New variable.
> (stop_reply_match_ptid, stop_reply_match_ptid_and_ws: New.
> (queued_stop_reply, peek_stop_reply): Adjust.
> (remote_get_pending_stop_replies): Rename to
> remote_notif_get_pending_events.
> (handle_notification): Move to remote-notif.c.
> (remote_async_get_pending_events_handler): Likewise.
> (remote_wait_as): Adjust to call remote_notif_parse.
> (remote_wait): Call QUEUE_is_empty (notif_reply_p).
> (_initialize_remote): Call QUEUE_alloc. Update caller.
> * remote.h: Include "remote-notif.h".
> (remote_notif_get_pending_replies):
Okay.
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2012-12-12 17:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 6:40 [PATCH 0/8, V4] A general notification in GDB RSP Yao Qi
2012-12-11 6:40 ` [PATCH 2/8] de-couple %Stop from notification: gdbserver Yao Qi
2012-12-12 17:06 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 5/8] Different notification from packets Yao Qi
2012-12-12 18:14 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 4/8] command 'set debug notification' Yao Qi
2012-12-11 7:06 ` Eli Zaretskii
2012-12-12 17:57 ` Pedro Alves
2012-12-12 18:59 ` Eli Zaretskii
2012-12-12 19:17 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 1/8] new queue.h in common/ Yao Qi
2012-12-12 17:05 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 7/8] Cleanup pending queues before resume in all-stop Yao Qi
2012-12-12 18:22 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 8/8] RSP notification 'Test' Yao Qi
2012-12-11 6:41 ` [PATCH 3/8] de-couple %Stop from notification: gdb Yao Qi
2012-12-12 17:32 ` Pedro Alves [this message]
2012-12-11 6:41 ` [PATCH 6/8] Handle notification for all-stop Yao Qi
2012-12-12 18:28 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C8BFB2.2050400@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox