From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31157 invoked by alias); 12 Dec 2012 17:32:48 -0000 Received: (qmail 31121 invoked by uid 22791); 12 Dec 2012 17:32:45 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 17:32:37 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCHWZ4l006813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Dec 2012 12:32:36 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBCHWYRK014013; Wed, 12 Dec 2012 12:32:35 -0500 Message-ID: <50C8BFB2.2050400@redhat.com> Date: Wed, 12 Dec 2012 17:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/8] de-couple %Stop from notification: gdb References: <1355208017-9204-1-git-send-email-yao@codesourcery.com> <1355208017-9204-4-git-send-email-yao@codesourcery.com> In-Reply-To: <1355208017-9204-4-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00413.txt.bz2 On 12/11/2012 06:40 AM, Yao Qi wrote: > 2012-12-11 Yao Qi > > * Makefile.in (REMOTE_OBS): Add "remote-notif.o". > (SFILES): Add "remote-notif.c". > (HFILES_NO_SRCDIR): Add "remote-notif.h" and "common/queue.h". > * remote-notif.c: New. Factored out from remote.c. > * remote-notif.h: New. > * remote.c: Include "remote-notif.h". > (stop_reply_xmalloc, do_stop_reply_xfree): > (remote_parse_stop_reply, remote_get_pending_stop_replies): > (remote_async_get_pending_events_handler): Remove declarations. > (remote_parse_stop_reply): Declare. > (pending_stop_reply): Remove. > (remote_async_get_pending_events_token): Move to > remote-notif.c. > (remote_close): Replace 'delete_async_event_handler' with > remote_notif_unregister_async_event_handler. > Don't call discard_pending_stop_replies. > (remote_start_remote): Replace code with remote_notif_parse > and remote_notif_get_pending_replies. > (remote_open_1): Replace 'create_async_event_handler' with > remote_notif_register_async_event_handler. > (extended_remote_attach_1): Call remote_notif_parse and > notif_stop_reply_push. > (struct stop_reply) : Remove. > : New field. > Callers update. > (stop_reply_queue): Change its type. > (stop_reply_xmalloc, do_stop_reply_xfree): Remove. > (remote_notif_remove_all): New. > (discard_pending_stop_replies): Update. > (remote_notif_stop_ack, stop_reply_dtr): New. > (remote_notif_stop_alloc_event): New. > (notif_client_stop): New variable. > (stop_reply_match_ptid, stop_reply_match_ptid_and_ws: New. > (queued_stop_reply, peek_stop_reply): Adjust. > (remote_get_pending_stop_replies): Rename to > remote_notif_get_pending_events. > (handle_notification): Move to remote-notif.c. > (remote_async_get_pending_events_handler): Likewise. > (remote_wait_as): Adjust to call remote_notif_parse. > (remote_wait): Call QUEUE_is_empty (notif_reply_p). > (_initialize_remote): Call QUEUE_alloc. Update caller. > * remote.h: Include "remote-notif.h". > (remote_notif_get_pending_replies): Okay. Thanks, -- Pedro Alves