Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: yao@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/8] command 'set debug notification'.
Date: Wed, 12 Dec 2012 18:59:00 -0000	[thread overview]
Message-ID: <83zk1j6qrc.fsf@gnu.org> (raw)
In-Reply-To: <50C8C564.6090405@redhat.com>

> Date: Wed, 12 Dec 2012 17:56:52 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
> 
> On 12/11/2012 07:06 AM, Eli Zaretskii wrote:
> > 
> >> > +  add_setshow_boolean_cmd ("notification", no_class, &notif_debug,
> >> > +			   _("\
> >> > +Set debugging of async remote notification."), _("\
> >> > +Show debugging of async remote notification."), _("\
> >> > +When non-zero, async remote notification specific"
> >> > +" internal debugging is enabled."),
> >      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > I think not "debugging" is enabled, but "debugging info" is enabled.
> 
> This command just enables/disables internal debugging/logging output,
> it is not about debug info, as in dwarf, etc.

Granted, I understand that.  If you suggest to say

  When non-zero, debugging output about async remote notifications is
  enabled.

then I have no objections.  But saying that "internal debugging is
enabled" is certainly inaccurate and perhaps even misleading, IMO.


  reply	other threads:[~2012-12-12 18:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11  6:40 [PATCH 0/8, V4] A general notification in GDB RSP Yao Qi
2012-12-11  6:40 ` [PATCH 2/8] de-couple %Stop from notification: gdbserver Yao Qi
2012-12-12 17:06   ` Pedro Alves
2012-12-11  6:41 ` [PATCH 3/8] de-couple %Stop from notification: gdb Yao Qi
2012-12-12 17:32   ` Pedro Alves
2012-12-11  6:41 ` [PATCH 6/8] Handle notification for all-stop Yao Qi
2012-12-12 18:28   ` Pedro Alves
2012-12-11  6:41 ` [PATCH 1/8] new queue.h in common/ Yao Qi
2012-12-12 17:05   ` Pedro Alves
2012-12-11  6:41 ` [PATCH 7/8] Cleanup pending queues before resume in all-stop Yao Qi
2012-12-12 18:22   ` Pedro Alves
2012-12-11  6:41 ` [PATCH 5/8] Different notification from packets Yao Qi
2012-12-12 18:14   ` Pedro Alves
2012-12-11  6:41 ` [PATCH 4/8] command 'set debug notification' Yao Qi
2012-12-11  7:06   ` Eli Zaretskii
2012-12-12 17:57     ` Pedro Alves
2012-12-12 18:59       ` Eli Zaretskii [this message]
2012-12-12 19:17         ` Pedro Alves
2012-12-11  6:41 ` [PATCH 8/8] RSP notification 'Test' Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zk1j6qrc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox