From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/8] de-couple %Stop from notification: gdbserver
Date: Wed, 12 Dec 2012 17:06:00 -0000 [thread overview]
Message-ID: <50C8B96B.7080600@redhat.com> (raw)
In-Reply-To: <1355208017-9204-3-git-send-email-yao@codesourcery.com>
puOn 12/11/2012 06:40 AM, Yao Qi wrote:
> 2012-12-11 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in (OBS): Add notif.o.
> (notif_h, queue_h): New.
Don't forget to remove this from the ChangeLog entry before
checking in, now that gdbserver tracks dependencies automatically.
> (notif.o): New rule.
>
> * notif.c, notif.h: New.
> * server.c: Include "notif.h".
> (struct vstop_notif) <next>: Remove.
> <base>: New field.
> (queue_stop_reply): Update.
> (push_event, send_next_stop_reply): Remove.
> (discard_queued_stop_replies): Update.
> (notif_stop): New variable.
> (handle_v_stopped): Remove.
> (handle_v_requests): Don't call handle_v_stopped. Call
> handle_ack_notif instead.
> (queue_stop_reply_callback): Call notif_event_enque instead
> of queue_stop_reply.
> (handle_status): Don't call send_next_stop_reply, call
> notif_write_event instead.
> (kill_inferior_callback): Likewise.
> (detach_or_kill_inferior_callback): Likewise.
> (main): Call initialize_notif.
> (process_serial_event): Call QUEUE_is_empty.
> (handle_target_event): Call notif_push instead of push event.
> * server.h: Remove declaration of push_event.
Write:
* server.h (push_event): Remove declaration.
Patch is okay.
Thanks!
--
Pedro Alves
next prev parent reply other threads:[~2012-12-12 17:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 6:40 [PATCH 0/8, V4] A general notification in GDB RSP Yao Qi
2012-12-11 6:40 ` [PATCH 2/8] de-couple %Stop from notification: gdbserver Yao Qi
2012-12-12 17:06 ` Pedro Alves [this message]
2012-12-11 6:41 ` [PATCH 6/8] Handle notification for all-stop Yao Qi
2012-12-12 18:28 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 3/8] de-couple %Stop from notification: gdb Yao Qi
2012-12-12 17:32 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 8/8] RSP notification 'Test' Yao Qi
2012-12-11 6:41 ` [PATCH 4/8] command 'set debug notification' Yao Qi
2012-12-11 7:06 ` Eli Zaretskii
2012-12-12 17:57 ` Pedro Alves
2012-12-12 18:59 ` Eli Zaretskii
2012-12-12 19:17 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 5/8] Different notification from packets Yao Qi
2012-12-12 18:14 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 7/8] Cleanup pending queues before resume in all-stop Yao Qi
2012-12-12 18:22 ` Pedro Alves
2012-12-11 6:41 ` [PATCH 1/8] new queue.h in common/ Yao Qi
2012-12-12 17:05 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C8B96B.7080600@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox