From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14225 invoked by alias); 12 Dec 2012 17:06:01 -0000 Received: (qmail 14200 invoked by uid 22791); 12 Dec 2012 17:05:58 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 17:05:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCH5njw003534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Dec 2012 12:05:49 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBCH5mxX007371; Wed, 12 Dec 2012 12:05:49 -0500 Message-ID: <50C8B96B.7080600@redhat.com> Date: Wed, 12 Dec 2012 17:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/8] de-couple %Stop from notification: gdbserver References: <1355208017-9204-1-git-send-email-yao@codesourcery.com> <1355208017-9204-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1355208017-9204-3-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00412.txt.bz2 puOn 12/11/2012 06:40 AM, Yao Qi wrote: > 2012-12-11 Yao Qi > > * Makefile.in (OBS): Add notif.o. > (notif_h, queue_h): New. Don't forget to remove this from the ChangeLog entry before checking in, now that gdbserver tracks dependencies automatically. > (notif.o): New rule. > > * notif.c, notif.h: New. > * server.c: Include "notif.h". > (struct vstop_notif) : Remove. > : New field. > (queue_stop_reply): Update. > (push_event, send_next_stop_reply): Remove. > (discard_queued_stop_replies): Update. > (notif_stop): New variable. > (handle_v_stopped): Remove. > (handle_v_requests): Don't call handle_v_stopped. Call > handle_ack_notif instead. > (queue_stop_reply_callback): Call notif_event_enque instead > of queue_stop_reply. > (handle_status): Don't call send_next_stop_reply, call > notif_write_event instead. > (kill_inferior_callback): Likewise. > (detach_or_kill_inferior_callback): Likewise. > (main): Call initialize_notif. > (process_serial_event): Call QUEUE_is_empty. > (handle_target_event): Call notif_push instead of push event. > * server.h: Remove declaration of push_event. Write: * server.h (push_event): Remove declaration. Patch is okay. Thanks! -- Pedro Alves