From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Sanjoy Das <sanjoy@playingwithpointers.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface.
Date: Wed, 17 Oct 2012 16:16:00 -0000 [thread overview]
Message-ID: <507ED9B1.8070201@redhat.com> (raw)
In-Reply-To: <871ugy896w.fsf@fleche.redhat.com>
On 10/16/2012 09:15 PM, Tom Tromey wrote:
>>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:
>
> Sanjoy> +2012-10-08 Sanjoy Das <sanjoy@playingwithpointers.com>
> Sanjoy> +
> Sanjoy> + * gdb.base/jit-reader.exp: New file. Test case for the jit-reader
> Sanjoy> + interface.
> Sanjoy> + * gdb.base/jithost.c: Do.
> Sanjoy> + * gdb.base/jithost.h: Do.
> Sanjoy> + * gdb.base/jitreader.c : Do.
>
> Thanks very much for doing this.
>
> I was concerned that this test should be native-only, but then I noticed
> that skip_shlib_tests checks isnative. So, no worries there.
Hmm, confused. :-)
# Return a 1 if we should skip shared library tests.
proc skip_shlib_tests {} {
# Run the shared library tests on native systems.
if {[isnative]} {
return 0
}
This means that shlib tests are never skipped on native, but
it doesn't prevent it from running elsewhere.
Should the test be native-only? If so, why? Doesn't the jit interface work
when debugging with remote targets (e.g., gdbserver)?
>
> Sanjoy> +set include_dir ${objdir}/../../
>
> I think this should use standard_output_file.
>
> This patch is ok with this change.
--
Pedro Alves
next prev parent reply other threads:[~2012-10-17 16:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 11:43 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-10-08 11:43 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-10-16 20:16 ` Tom Tromey
2012-10-17 16:16 ` Pedro Alves [this message]
2012-10-17 16:27 ` Tom Tromey
2012-10-17 16:35 ` Pedro Alves
2012-10-17 16:29 ` Pedro Alves
2012-10-08 11:43 ` [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects Sanjoy Das
2012-10-08 12:34 ` Eli Zaretskii
2012-10-16 20:13 ` Tom Tromey
2012-10-08 11:43 ` [PATCH 1/3] Fix segfault when unwinding JIT frames using a custom reader Sanjoy Das
2012-10-16 20:14 ` Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2012-11-04 16:59 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-11-04 17:00 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-12-01 20:48 ` Jan Kratochvil
2012-12-07 9:15 ` Sanjoy Das
2012-12-10 16:38 ` Jan Kratochvil
2013-01-08 20:40 ` Sanjoy Das
2013-01-09 12:37 ` Jan Kratochvil
2013-01-13 21:58 ` Sanjoy Das
2013-01-14 3:52 ` Jan Kratochvil
2012-09-24 4:48 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-09-24 4:48 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-09-27 21:00 ` Tom Tromey
2012-09-18 4:30 [PATCH 0/3] Fix recent breakage in the JIT reader interface Sanjoy Das
2012-09-18 4:30 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-09-18 19:36 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507ED9B1.8070201@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sanjoy@playingwithpointers.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox