Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface.
Date: Mon, 14 Jan 2013 03:52:00 -0000	[thread overview]
Message-ID: <20130114035208.GA26555@host2.jankratochvil.net> (raw)
In-Reply-To: <CAMiUf7dQcTnY0XtTS7UL85+gjok3NW5XUzrmd8YoUTW4EHQFYw@mail.gmail.com>

On Sun, 13 Jan 2013 22:57:34 +0100, Sanjoy Das wrote:
> 2. Use SLASH_STRING instead of a raw backslash when computing the full
> path of a plugin (in the second patch).

I have considered it pre-approved for a commit with the few changes.

But I see you can improve:
+    so_name = xstrprintf ("%s%s%s", SLASH_STRING, jit_reader_dir, args);
->
+    so_name = xstrprintf ("%s" SLASH_STRING "%s", jit_reader_dir, args);

So the patchset is approved again with this change.


Thanks,
Jan


  reply	other threads:[~2013-01-14  3:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-04 16:59 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-11-04 17:00 ` [PATCH 1/3] Fix segfault when unwinding JIT frames using a custom reader Sanjoy Das
2012-12-01 20:25   ` Jan Kratochvil
2012-11-04 17:00 ` [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects Sanjoy Das
2013-01-09  9:36   ` Jan Kratochvil
2012-11-04 17:00 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-12-01 20:48   ` Jan Kratochvil
2012-12-07  9:15     ` Sanjoy Das
2012-12-10 16:38       ` Jan Kratochvil
2013-01-08 20:40         ` Sanjoy Das
2013-01-09 12:37           ` Jan Kratochvil
2013-01-13 21:58             ` Sanjoy Das
2013-01-14  3:52               ` Jan Kratochvil [this message]
2012-11-08 21:06 ` [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Tom Tromey
  -- strict thread matches above, loose matches on Subject: below --
2012-10-08 11:43 Sanjoy Das
2012-10-08 11:43 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-10-16 20:16   ` Tom Tromey
2012-10-17 16:16     ` Pedro Alves
2012-10-17 16:27       ` Tom Tromey
2012-10-17 16:35         ` Pedro Alves
2012-10-17 16:29   ` Pedro Alves
2012-09-24  4:48 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-09-24  4:48 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-09-27 21:00   ` Tom Tromey
2012-09-18  4:30 [PATCH 0/3] Fix recent breakage in the JIT reader interface Sanjoy Das
2012-09-18  4:30 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-09-18 19:36   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130114035208.GA26555@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sanjoy@playingwithpointers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox