From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97635-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27988 invoked by alias); 14 Jan 2013 03:52:21 -0000
Received: (qmail 27975 invoked by uid 22791); 14 Jan 2013 03:52:20 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Jan 2013 03:52:14 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0E3qC1s030979	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Sun, 13 Jan 2013 22:52:12 -0500
Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0E3q8Gg016640	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Sun, 13 Jan 2013 22:52:11 -0500
Date: Mon, 14 Jan 2013 03:52:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface.
Message-ID: <20130114035208.GA26555@host2.jankratochvil.net>
References: <1352048631-25042-1-git-send-email-sanjoy@playingwithpointers.com> <1352048631-25042-4-git-send-email-sanjoy@playingwithpointers.com> <20121201204751.GB22812@host2.jankratochvil.net> <CAMiUf7f5EXkxi7hD4Rm1bU=_tUUtB3vgLbvzB4S-qbWYgh4_fQ@mail.gmail.com> <20121210163800.GA24342@host2.jankratochvil.net> <CAMiUf7dcxE-nt7OYd2RrKTeMGBBb0-1Buod+KKsYrdu1JYJFTg@mail.gmail.com> <20130109123706.GB6415@host2.jankratochvil.net> <CAMiUf7dQcTnY0XtTS7UL85+gjok3NW5XUzrmd8YoUTW4EHQFYw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMiUf7dQcTnY0XtTS7UL85+gjok3NW5XUzrmd8YoUTW4EHQFYw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00265.txt.bz2

On Sun, 13 Jan 2013 22:57:34 +0100, Sanjoy Das wrote:
> 2. Use SLASH_STRING instead of a raw backslash when computing the full
> path of a plugin (in the second patch).

I have considered it pre-approved for a commit with the few changes.

But I see you can improve:
+    so_name = xstrprintf ("%s%s%s", SLASH_STRING, jit_reader_dir, args);
->
+    so_name = xstrprintf ("%s" SLASH_STRING "%s", jit_reader_dir, args);

So the patchset is approved again with this change.


Thanks,
Jan