From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface.
Date: Mon, 10 Dec 2012 16:38:00 -0000 [thread overview]
Message-ID: <20121210163800.GA24342@host2.jankratochvil.net> (raw)
In-Reply-To: <CAMiUf7f5EXkxi7hD4Rm1bU=_tUUtB3vgLbvzB4S-qbWYgh4_fQ@mail.gmail.com>
On Fri, 07 Dec 2012 10:14:45 +0100, Sanjoy Das wrote:
> > I do not understand why you do not use gdb/jit.h here? This file is
> > a duplicate. Sorry if it was already discussed during initial JIT review.
>
> I don't think this has been discussed, but my justification is that
> we'd want the JIT tests to break if we make ABI incompatible changes
> to the structures in jit.h (which, loosely speaking, are part of GDB's
> "interface").
OK, that makes sense. But in such case please make there a clear separate
jit.h copy (with a different name and some added #ifdef/#error or something
like that protection so that if one mistakenly includes gdb/jit.h it gets
error-reported, with an explanation you made to me now above).
> As an aside, something seems to have gone wrong with my SSH keys and I
> was wondering if someone could commit my work (patches attached) for
> me, if that is permissible.
While I can commit it for you I find it would be better to contact
<overseers at sourceware.org>. Still contact me off-list if you do want to
commit it by myself (it is OK, it is commonly done).
Thanks,
Jan
next prev parent reply other threads:[~2012-12-10 16:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 16:59 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-11-04 17:00 ` [PATCH 1/3] Fix segfault when unwinding JIT frames using a custom reader Sanjoy Das
2012-12-01 20:25 ` Jan Kratochvil
2012-11-04 17:00 ` [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects Sanjoy Das
2013-01-09 9:36 ` Jan Kratochvil
2012-11-04 17:00 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-12-01 20:48 ` Jan Kratochvil
2012-12-07 9:15 ` Sanjoy Das
2012-12-10 16:38 ` Jan Kratochvil [this message]
2013-01-08 20:40 ` Sanjoy Das
2013-01-09 12:37 ` Jan Kratochvil
2013-01-13 21:58 ` Sanjoy Das
2013-01-14 3:52 ` Jan Kratochvil
2012-11-08 21:06 ` [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2012-10-08 11:43 Sanjoy Das
2012-10-08 11:43 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-10-16 20:16 ` Tom Tromey
2012-10-17 16:16 ` Pedro Alves
2012-10-17 16:27 ` Tom Tromey
2012-10-17 16:35 ` Pedro Alves
2012-10-17 16:29 ` Pedro Alves
2012-09-24 4:48 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-09-24 4:48 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-09-27 21:00 ` Tom Tromey
2012-09-18 4:30 [PATCH 0/3] Fix recent breakage in the JIT reader interface Sanjoy Das
2012-09-18 4:30 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-09-18 19:36 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210163800.GA24342@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sanjoy@playingwithpointers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox