From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9535 invoked by alias); 10 Dec 2012 16:38:22 -0000 Received: (qmail 9346 invoked by uid 22791); 10 Dec 2012 16:38:18 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Dec 2012 16:38:06 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBAGc45c032686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Dec 2012 11:38:05 -0500 Received: from host2.jankratochvil.net (ovpn-116-35.ams2.redhat.com [10.36.116.35]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBAGc0ne014986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 10 Dec 2012 11:38:03 -0500 Date: Mon, 10 Dec 2012 16:38:00 -0000 From: Jan Kratochvil To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface. Message-ID: <20121210163800.GA24342@host2.jankratochvil.net> References: <1352048631-25042-1-git-send-email-sanjoy@playingwithpointers.com> <1352048631-25042-4-git-send-email-sanjoy@playingwithpointers.com> <20121201204751.GB22812@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00253.txt.bz2 On Fri, 07 Dec 2012 10:14:45 +0100, Sanjoy Das wrote: > > I do not understand why you do not use gdb/jit.h here? This file is > > a duplicate. Sorry if it was already discussed during initial JIT review. > > I don't think this has been discussed, but my justification is that > we'd want the JIT tests to break if we make ABI incompatible changes > to the structures in jit.h (which, loosely speaking, are part of GDB's > "interface"). OK, that makes sense. But in such case please make there a clear separate jit.h copy (with a different name and some added #ifdef/#error or something like that protection so that if one mistakenly includes gdb/jit.h it gets error-reported, with an explanation you made to me now above). > As an aside, something seems to have gone wrong with my SSH keys and I > was wondering if someone could commit my work (patches attached) for > me, if that is permissible. While I can commit it for you I find it would be better to contact . Still contact me off-list if you do want to commit it by myself (it is OK, it is commonly done). Thanks, Jan