From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3255 invoked by alias); 17 Oct 2012 16:16:00 -0000 Received: (qmail 3223 invoked by uid 22791); 17 Oct 2012 16:15:57 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Oct 2012 16:15:49 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HGFlqY011819 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 17 Oct 2012 12:15:47 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9HGFjFC030845; Wed, 17 Oct 2012 12:15:46 -0400 Message-ID: <507ED9B1.8070201@redhat.com> Date: Wed, 17 Oct 2012 16:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: Tom Tromey CC: Sanjoy Das , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface. References: <1349696849-9056-1-git-send-email-sanjoy@playingwithpointers.com> <1349696849-9056-4-git-send-email-sanjoy@playingwithpointers.com> <871ugy896w.fsf@fleche.redhat.com> In-Reply-To: <871ugy896w.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00276.txt.bz2 On 10/16/2012 09:15 PM, Tom Tromey wrote: >>>>>> "Sanjoy" == Sanjoy Das writes: > > Sanjoy> +2012-10-08 Sanjoy Das > Sanjoy> + > Sanjoy> + * gdb.base/jit-reader.exp: New file. Test case for the jit-reader > Sanjoy> + interface. > Sanjoy> + * gdb.base/jithost.c: Do. > Sanjoy> + * gdb.base/jithost.h: Do. > Sanjoy> + * gdb.base/jitreader.c : Do. > > Thanks very much for doing this. > > I was concerned that this test should be native-only, but then I noticed > that skip_shlib_tests checks isnative. So, no worries there. Hmm, confused. :-) # Return a 1 if we should skip shared library tests. proc skip_shlib_tests {} { # Run the shared library tests on native systems. if {[isnative]} { return 0 } This means that shlib tests are never skipped on native, but it doesn't prevent it from running elsewhere. Should the test be native-only? If so, why? Doesn't the jit interface work when debugging with remote targets (e.g., gdbserver)? > > Sanjoy> +set include_dir ${objdir}/../../ > > I think this should use standard_output_file. > > This patch is ok with this change. -- Pedro Alves