From: Yao Qi <yao@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: <jan.kratochvil@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [patch] entry values: Fix resolving in inlined frames
Date: Mon, 08 Oct 2012 09:18:00 -0000 [thread overview]
Message-ID: <50729A43.9060702@codesourcery.com> (raw)
In-Reply-To: <201210051518.q95FID1J003796@glazunov.sibelius.xs4all.nl>
On 10/05/2012 11:18 PM, Mark Kettenis wrote:
>> + /* Skip any inlined frames, entry value call sites work between real
>> >+ functions. They do not make sense between inline functions as even PC
>> >+ does not change there. */
> I realize that you're not a native speaker, but a big part of the
> problem is that there are a lot of grammatical mistakes in your
> english. Can you get some help from a native speaker to make sure the
> comments in the code make sense?
I am not an English native speaker either, and I do believe my comments
in patches and mails sometimes make troubles to people who read them.
However, I get a lot of kindly help from people here to correct or
improve them, and I really appreciate their helps. If you find the
mistakes, feel free to point them out, or if you can't understand the
words, ask the author to clarify. It is impractical, at least for me,
to find a native speaker dedicated to polishing comments for me.
--
Yao
next prev parent reply other threads:[~2012-10-08 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 12:41 Jan Kratochvil
2012-10-05 15:18 ` Mark Kettenis
2012-10-05 15:45 ` Jan Kratochvil
2012-10-05 16:34 ` Joel Brobecker
2012-10-16 8:47 ` [comment commit] " Jan Kratochvil
2012-10-08 9:18 ` Yao Qi [this message]
2012-10-15 19:16 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50729A43.9060702@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox